Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of all dependencies #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eira-fransham
Copy link

@eira-fransham eira-fransham commented Jan 7, 2021

This change is Reviewable

Copy link
Collaborator

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@kvark
Copy link
Collaborator

kvark commented Jan 7, 2021

Code needs to be fixed, like CI errors indicate

@jameshiew
Copy link

This branch compiles for me now locally, maybe the Travis build could be attempted again?

@kvark
Copy link
Collaborator

kvark commented May 4, 2021

bors r+

bors bot added a commit that referenced this pull request May 4, 2021
118: Update to latest version of all dependencies r=kvark a=Vurich



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/rustgd/collision-rs/118)
<!-- Reviewable:end -->


Co-authored-by: Jef <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 4, 2021

Build failed:

@kvark
Copy link
Collaborator

kvark commented May 4, 2021

Errors still see legitimate?

14 | use genmesh::generators::{IndexedPolygon, SharedVertex, SphereUV};

   |                                                         ^^^^^^^^

   |                                                         |

   |                                                         no `SphereUV` in `generators`

   |                                                         help: a similar name exists in the module (notice the capitalization): `SphereUv`

@eadf
Copy link
Contributor

eadf commented Sep 21, 2021

@Vurich I have rebased your changes and fixed the last build errors here
Please take what you need to make this PR going.

The main issue was cgmath::Point3::from(mint::Vector), for some reason From/Into didn't want to co-operate. So I settled for a less effective: Point3::from(*v.pos.as_ref()), but at least It runs.

I will keep rebasing that branch for a while, keeping it updated with master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants