Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.10.0 #1020

Merged
merged 2 commits into from
Jul 2, 2021
Merged

0.10.0 #1020

merged 2 commits into from
Jul 2, 2021

Conversation

drager
Copy link
Member

@drager drager commented Jun 29, 2021

Fixes #951

@drager drager mentioned this pull request Jun 29, 2021
Closed
simlay
simlay approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@simlay simlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured I'd do a drive by review (hope that's okay).

Only a minor nit on the Update rust step in CI as I think it may be unneeded/redundant.

Looks good otherwise!

I tested this out locally and noticed that when I ran wasm-pack test --headless --{firefox,safari,chrome}, I saw:
image

I'm thinking this is because it's not in the installed list wherever it's hosted but I'm not sure.

@drager
Copy link
Member Author

drager commented Jun 30, 2021

Figured I'd do a drive by review (hope that's okay).

Only a minor nit on the Update rust step in CI as I think it may be unneeded/redundant.

Looks good otherwise!

I tested this out locally and noticed that when I ran wasm-pack test --headless --{firefox,safari,chrome}, I saw:
image

I'm thinking this is because it's not in the installed list wherever it's hosted but I'm not sure.

Absolutely! Appreciate it!

Yeah, I'm pretty sure it's warns now since there's no new release just yet.

@drager drager force-pushed the 0.10.0 branch 2 times, most recently from 575a381 to fe81b72 Compare July 2, 2021 10:56
@drager drager removed the work in progress do not merge! label Jul 2, 2021
@drager drager changed the title [WIP] 0.10.0 0.10.0 Jul 2, 2021
@drager drager force-pushed the 0.10.0 branch 3 times, most recently from 01bd864 to 097f131 Compare July 2, 2021 11:28
@drager drager merged commit eceb5df into master Jul 2, 2021
@drager drager deleted the 0.10.0 branch July 2, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simlay simlay simlay approved these changes

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release a new version
2 participants
@drager @simlay