Issue #435: deleting wrong option in heuristic test #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #435
What's Causing the Bug
The bug seems to happen exclusively for options with no value set, as discussed here. To figure out why, first let's take a closer look at the
deleteItem
method:Now, my understanding is that if there are multiple items with values as null, indexOf might always return the index of the first item with null value, not necessarily the one we want to delete.
Measures
One way to fix this issue is to assign a unique identifier to each item when it is created, and use this identifier to find the correct item to delete. This ensures that even items with identical visible properties can be correctly distinguished. For this, I have attached a timestamp property to the items.
Working Demo
ruxailab-bugfix-435-2024_04_17.mp4