Improve player vehicle exit logic #726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The player can now no longer accelerate whilst exiting a vehicle. This prevents Claude from floating next to the vehicle if the player accelerates during the exit animation.
Lihis
suggested changes
Oct 26, 2019
rwgame/states/IngameState.cpp
Outdated
| // The player cannot accelerate while exiting. | ||
| // He can, however, brake in the opposite direction of movement. | ||
| int velocitySign = vehicle->getVelocity() >= 0 ? 1 : -1; | ||
| int movementSign = movement.x >= 0 ? 1 : -1; |
There was a problem hiding this comment.
This and lines below have some tab characters, indent with spaces only.
|
I replaced those tab character |
Lihis
approved these changes
Oct 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 18.12% 11.14% -6.99%
==========================================
Files 252 252
Lines 22938 22946 +8
Branches 5769 5794 +25
==========================================
- Hits 4158 2557 -1601
- Misses 17659 18860 +1201
- Partials 1121 1529 +408
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The player can now no longer accelerate whilst exiting a vehicle.
This prevents Claude from floating next to the vehicle if the player accelerates during the exit animation.
At the same time, this behaviour is closer to the exit vehicle behaviour in the actual game.