Clean lazy_loader from module namespace
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't realize the size calculation function was parsing all nested modules using a breadth first search, hence loading all the modules. Writing a test for memory is not practical apparently since we're dealing with pointers here. |
kushaangupta
changed the title
lazy_loader from module namespace
|
The memory test didn't work as expected, but could we add a test similar to what they did at mne-python? https://github.com/mne-tools/mne-python/blob/main/mne/tests/test_import_nesting.py#L230 |
|
That was helpful! I've added a meaningful test case for lazy loading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14