Fix latest dart2js
and dart2wasm
failing to compile due to invalid method signatures detected (#1326)
#1329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1326 (
just_audio_web
issue with latestdart2js
anddart2wasm
compilers) by adding more strict type signature to the functions. Dart incorrectly decides that(event)
is adynamic
type, thus failing to compile. Refactoring that to(Event event)
fixes the issue.If there's anything else I can or should do, please, let me know!