Feature/release fixes #1586
Merged
Feature/release fixes #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fini Jastrow <[email protected]>
[why]
The code needlessly create two language ID17 even if ID16 is only one
entry / one languange. ID17 is always the same for both languages.
This is an example for the wrong way:
======== BlexMonoNerdFont-Text.ttf ========
SFNT Fullname ID 4 BlexMono Nerd Font Text
SFNT Family ID 1 BlexMono Nerd Font Text
SFNT SubFamily ID 2 Regular
SFNT Pref Family ID 16 BlexMono Nerd Font
SFNT Pref Styles ID 17 ('Text', 'Text')
SFNT PS Name ID 6 BlexMonoNF-Text
SFNT Compatible ID 18 -
SFNT CID findfont ID 20 -
SFNT WWS Family ID 21 -
SFNT WWS SubFamily ID 22 -
PS fontname BlexMonoNF-Text
PS fullname BlexMono Nerd Font Text
PS familyname BlexMono Nerd Font Text
fondname None
This is an example for the correct way (two ID17 when we have two ID16):
======== NotoSerifCondensedNerdFont-BlackItalic.ttf ========
SFNT Fullname ID 4 NotoSerif Condensed NF Black Italic
SFNT Family ID 1 NotoSerif Cond NF Black
SFNT SubFamily ID 2 Italic
SFNT Pref Family ID 16 ('NotoSerif Condensed Nerd Font', 'NotoSerif Cond NF')
SFNT Pref Styles ID 17 ('Black Italic', 'Black Italic')
SFNT PS Name ID 6 NotoSerifCondensedNF-BlackItalic
SFNT Compatible ID 18 -
SFNT CID findfont ID 20 -
SFNT WWS Family ID 21 -
SFNT WWS SubFamily ID 22 -
PS fontname NotoSerifCondensedNF-BlackItalic
PS fullname NotoSerif Condensed NF Black Italic
PS familyname NotoSerif Cond NF Black
fondname None
Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
[why] With commit 72c335d Update M PLUS the fonts CodeLatin and CodeLatinExpanded got renamed to CodeLatin50 and CodeLatin60. The old build artifacts still linger while the new fonts were added. Signed-off-by: Fini Jastrow <[email protected]>
[why] We have now fonts where names for multiple languages are set (differently) but we need to compare only the base language which is English US. Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
[why] Modifier on their own are not allowed (except "Demi"). The previous commit where we changed the CodeClimate fix from ' ' to '' allowed any modifier to be a stand alone detected word. This resulted in this font name: RecMonoCasual Nerd Font Propo Semi [how] Remove the cumbesome CodeClimate kludge completely, it just makes the code more complex without any real benefit. Codeclimate just complains because our tables look so "similar" :rolleyes: That's data dude! Signed-off-by: Fini Jastrow <[email protected]>
[why] "RecMonoSemi" looks a bit broken. [how] Unchanged version "RecMonoSemicasual" is two chars too long for NFP. This is independent on makegroups mode, because the PS name is affected. Use "RecMonoSmCasual" which is just the right length and still the original is discernible (I guess). Signed-off-by: Fini Jastrow <[email protected]>
Has been forgotten... Signed-off-by: Fini Jastrow <[email protected]>
[why] The keep-regular rule should add 'Regular' as weight if there is no weight (e.g. Bold) or style (e.g. Italic). But when a font does have neither but has a widths specifier it is also not added. [how] Check for some conrete weight and not only any entry in the weight token, because we - unfortunately - mix weights and widths in that token set. We do not need to check the styles because it is technically impossible for it to comtain Regular and something else. Signed-off-by: Fini Jastrow <[email protected]>
We do not need "Condensed Regular" as ID17, a simple "Condensed" is enough. Signed-off-by: Fini Jastrow <[email protected]>
Hmm, this is probably not what we want, but I would like to keep the commit for future reference. This reverts commit ecca0a4.
CodeClimate issue Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
feature/release-fixes
branch
from
f56ef30 to
8d200ed
Compare
|
This is so ridiculous...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues encountered when releasing
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)