-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bazel icon #1610
Improve bazel icon #1610
Conversation
Thanks for the improvement! codepoint |
That's fair! It was eyeballed. I could clean it up a bit.
Yeah I think a few icons could benefit from some transparent gaps. They show up so much better that way IMO. |
Codepoint Also remember having seen |
KotlinThe striped logo is obsolete, with the one rouchgly K shaped block we have already the latest and correct one. FirebaseThey have a monochrome icon, see https://firebase.google.com/brand-guidelines/ RubyDoes not have a canonical monochrome icon, https://www.ruby-lang.org/en/about/logo/ BazelThere is no monochrome icon, but from the design ideas presented here https://blog.bazel.build/2017/07/05/new-logo-and-homepage.html it seems that the proposed change by zaucy is 'correct', at least if one does not want just the outside lines of the cubes. |
[why] The Bazel icon might look nicer with gaps between the surfaces of the cubes. That is halfway in-line with the design idea of their logo. See PR ryanoasis#1610 and link https://blog.bazel.build/2017/07/05/new-logo-and-homepage.html [how] Based on the idea from Ezekiel Warren the Bazel icon gets gaps between the surfaces of the cubes. For this we use the skeleton svg icon of the Bazel website and construct from scratch a new outline to represent the cube surfaces. The original svg used lines with a width to create the image, which is not compatible to fonts. Signed-off-by: Fini Jastrow <[email protected]>
61de0c6
to
db6bdf0
Compare
2aebd9f
to
736e124
Compare
This reverts commit 0c1f008. [why] We keep the seti icons unmodified and instead add them as custom if we introduce any change.
[why] The Bazel icon might look nicer with gaps between the surfaces of the cubes. That is halfway in-line with the design idea of their logo. See PR ryanoasis#1610 and link https://blog.bazel.build/2017/07/05/new-logo-and-homepage.html [how] Based on the idea from Ezekiel Warren the Bazel icon gets gaps between the surfaces of the cubes. For this we use the skeleton svg icon of the Bazel website and construct from scratch a new outline to represent the cube surfaces. The original svg used lines with a width to create the image, which is not compatible to fonts. Signed-off-by: Fini Jastrow <[email protected]>
[why] Improve legibility. The full icon is in fact a multicolor icon and the design depends on being rendered in multiple different colors. That is impossible for fonts. So we should probably use their flat (mono-color) icon instead, which hints the different 'flaps' through gaps instead of colors. [note] Both icons (the old and the new) contradict rules given by Firebase to use the logo. But that can not be helped in a icon font, as we just have one color of undetermined hue. Signed-off-by: Fini Jastrow <[email protected]>
[why] Improve legibility by having gaps between the gemstone surfaces. [how] There is no official monochrome icon. Found one free pixel one and converted that to outline. Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
2586922
to
f3949ee
Compare
@allcontributors please add @zaucy for code |
I've put up a pull request to add @zaucy! 🎉 |
Description
Improved bazel icon. The old icon didn't have the separation lines which makes it look bad when used in applications such as neovim or other TUI applications.
Any background context you can provide?
Bazel icon was modified by myself
Screenshots (if appropriate or helpful)