Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bazel icon #1610

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Improve bazel icon #1610

merged 6 commits into from
Apr 26, 2024

Conversation

zaucy
Copy link
Contributor

@zaucy zaucy commented Apr 15, 2024

Description

Improved bazel icon. The old icon didn't have the separation lines which makes it look bad when used in applications such as neovim or other TUI applications.

Any background context you can provide?

Bazel icon was modified by myself

Screenshots (if appropriate or helpful)

old new
image TODO

@Finii
Copy link
Collaborator

Finii commented Apr 15, 2024

Thanks for the improvement!

codepoint e63a aka nf-seti-bazel

@Finii
Copy link
Collaborator

Finii commented Apr 15, 2024

image

Turns out good, just one nitpick, the gap seems to be non-constant in width? A bit narrower at A than at B?

image

@Finii
Copy link
Collaborator

Finii commented Apr 15, 2024

I wonder if these two have the same 'problem'?

image

Kotlin and Rubi

image

image
But then, 'rubi' is a bad search term

@Finii
Copy link
Collaborator

Finii commented Apr 15, 2024

And firebase?

image

And we have some alternative kotlin icon in the repo, which would turn out the same because fonts just have color or transparent, so one needs to crate the gaps.

image


As usual, each bug is a rabbit hole.

@zaucy
Copy link
Contributor Author

zaucy commented Apr 15, 2024

Turns out good, just one nitpick, the gap seems to be non-constant in width? A bit narrower at A than at B?

That's fair! It was eyeballed. I could clean it up a bit.

I wonder if these two have the same 'problem'?

Yeah I think a few icons could benefit from some transparent gaps. They show up so much better that way IMO.

@Finii
Copy link
Collaborator

Finii commented Apr 22, 2024

Codepoint E552, related:

Also remember having seen E511 with eyes 🤔

@Finii
Copy link
Collaborator

Finii commented Apr 26, 2024

Kotlin

The striped logo is obsolete, with the one rouchgly K shaped block we have already the latest and correct one.
See assets in https://kotlinlang.org/docs/kotlin-brand-assets.html

Firebase

They have a monochrome icon, see https://firebase.google.com/brand-guidelines/
Will change.

Ruby

Does not have a canonical monochrome icon, https://www.ruby-lang.org/en/about/logo/

Bazel

There is no monochrome icon, but from the design ideas presented here https://blog.bazel.build/2017/07/05/new-logo-and-homepage.html it seems that the proposed change by zaucy is 'correct', at least if one does not want just the outside lines of the cubes.

image

@Finii
Copy link
Collaborator

Finii commented Apr 26, 2024

Starting with their monochrome icon

image

image

image

Finii added a commit to zaucy/nerd-fonts that referenced this pull request Apr 26, 2024
[why]
The Bazel icon might look nicer with gaps between the surfaces of the
cubes.
That is halfway in-line with the design idea of their logo.

See PR ryanoasis#1610 and link
https://blog.bazel.build/2017/07/05/new-logo-and-homepage.html

[how]
Based on the idea from Ezekiel Warren the Bazel icon gets gaps between
the surfaces of the cubes.
For this we use the skeleton svg icon of the Bazel website and construct
from scratch a new outline to represent the cube surfaces. The original
svg used lines with a width to create the image, which is not compatible
to fonts.

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii force-pushed the chore/update-bazel-icon branch from 61de0c6 to db6bdf0 Compare April 26, 2024 08:31
@Finii
Copy link
Collaborator

Finii commented Apr 26, 2024

Ruby monochrome ...

image

The left one would be my favorite, but the angles are all wrong 😒
The one in the middle looks too coarse for my eyes. Hmm.

image

This looks nice ;-)

@Finii Finii force-pushed the chore/update-bazel-icon branch from 2aebd9f to 736e124 Compare April 26, 2024 10:54
@Finii
Copy link
Collaborator

Finii commented Apr 26, 2024

image

zaucy and others added 6 commits April 26, 2024 12:58
This reverts commit 0c1f008.

[why]
We keep the seti icons unmodified and instead add them as custom if we
introduce any change.
[why]
The Bazel icon might look nicer with gaps between the surfaces of the
cubes.
That is halfway in-line with the design idea of their logo.

See PR ryanoasis#1610 and link
https://blog.bazel.build/2017/07/05/new-logo-and-homepage.html

[how]
Based on the idea from Ezekiel Warren the Bazel icon gets gaps between
the surfaces of the cubes.
For this we use the skeleton svg icon of the Bazel website and construct
from scratch a new outline to represent the cube surfaces. The original
svg used lines with a width to create the image, which is not compatible
to fonts.

Signed-off-by: Fini Jastrow <[email protected]>
[why]
Improve legibility. The full icon is in fact a multicolor icon and the
design depends on being rendered in multiple different colors. That is
impossible for fonts. So we should probably use their flat (mono-color)
icon instead, which hints the different 'flaps' through gaps instead of
colors.

[note]
Both icons (the old and the new) contradict rules given by Firebase to
use the logo. But that can not be helped in a icon font, as we just have
one color of undetermined hue.

Signed-off-by: Fini Jastrow <[email protected]>
[why]
Improve legibility by having gaps between the gemstone surfaces.

[how]
There is no official monochrome icon. Found one free pixel one and
converted that to outline.

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii force-pushed the chore/update-bazel-icon branch from 2586922 to f3949ee Compare April 26, 2024 10:59
@Finii Finii merged commit 7c7b01b into ryanoasis:master Apr 26, 2024
0 of 4 checks passed
@Finii
Copy link
Collaborator

Finii commented Apr 26, 2024

@allcontributors please add @zaucy for code

Copy link
Contributor

@Finii

I've put up a pull request to add @zaucy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants