Added tests from reported issues about Generics

ryanrolds · Jan 29, 2023 · 702b704 · 702b704
1 parent b2e9cfd
commit 702b704
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/testdata/sqlx_examples/correct_generics.go b/testdata/sqlx_examples/correct_generics.go
diff --git a/testdata/sqlx_examples/expected_results.txt b/testdata/sqlx_examples/expected_results.txt
@@ -1,3 +1,5 @@
 # github.com/ryanrolds/sqlclosecheck/testdata/sqlx_examples
+testdata/sqlx_examples/failure_generics.go:6:21: Rows/Stmt was not closed
+testdata/sqlx_examples/failure_generics.go:13:21: Rows/Stmt was not closed
 testdata/sqlx_examples/missing_close.go:10:24: Rows/Stmt was not closed
 testdata/sqlx_examples/non_defer_close.go:30:12: Close should use defer
diff --git a/testdata/sqlx_examples/failure_generics.go b/testdata/sqlx_examples/failure_generics.go
@@ -0,0 +1,17 @@
+package sqlx_examples
+
+import "database/sql"
+
+func SqlCloseCheck(db *sql.DB, a int) {
+	rows, _ := db.Query("select id from tb") // <- detected OK
+	for rows.Next() {
+
+	}
+}
+
+func SqlCloseCheckG[T ~int64](db *sql.DB, a T) {
+	rows, _ := db.Query("select id from tb") // <- not detected KO
+	for rows.Next() {
+
+	}
+}