Don't show "There are too many failures to display" if maxNumberOfFai… (

#194) * Don't show "There are too many failures to display" if maxNumberOfFailures is set to zero * Remove unnecessary dividers in SlackClient_generate_blocks.spec.ts
ryanrosello-og · Sep 28, 2024 · 0b017eb · 0b017eb
1 parent b05eeae
commit 0b017eb
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -8,7 +8,6 @@
     "zod": "^3.22.4"
   },
   "devDependencies": {
-    "@playwright/test": "^1.46.1",
     "@slack/types": "^2.14.0",
     "@playwright/test": "^1.47.0",
     "@typescript-eslint/eslint-plugin": "^5.30.6",
@@ -36,7 +35,7 @@
     "cli-debug": "yarn build && npx . -c ./cli_config.json -j ./tests/test_data/valid_test_results.json"
   },
   "name": "playwright-slack-report",
-  "version": "1.1.86",
+  "version": "1.1.88",
   "bin": {
     "playwright-slack-report": "dist/cli.js"
   },

diff --git a/src/LayoutGenerator.ts b/src/LayoutGenerator.ts
@@ -72,7 +72,7 @@ const generateFailures = async (
     });
   }
 
-  if (summaryResults.failures.length > maxNumberOfFailures) {
+  if (maxNumberOfFailures > 0 && summaryResults.failures.length > maxNumberOfFailures) {
     fails.push({
       type: 'section',
       text: {
@@ -81,6 +81,11 @@ const generateFailures = async (
       },
     });
   }
+
+  if (fails.length === 0) {
+    return [];
+  }
+
   return [
     {
       type: 'divider',

diff --git a/src/SlackClient.ts b/src/SlackClient.ts
@@ -126,6 +126,10 @@ export default class SlackClient {
   }) {
     const result = [];
     const blocks = await generateFailures(summaryResults, maxNumberOfFailures);
+    if (blocks.length === 0) {
+      return result;
+    }
+
     const fallbackText = generateFallbackText(summaryResults);
     for (const channel of channelIds) {
       // under test

diff --git a/tests/SlackClient_generate_blocks.spec.ts b/tests/SlackClient_generate_blocks.spec.ts
@@ -172,9 +172,6 @@ test.describe('SlackClient.generateBlocks()', () => {
           text: '\n*BuildID* :\t9sdcv-312432-3134',
         },
       },
-      {
-        type: 'divider',
-      },
     ]);
   });
 
@@ -224,9 +221,6 @@ test.describe('SlackClient.generateBlocks()', () => {
           text: '✅ *0* | ❌ *1* | ⏩ *1*',
         },
       },
-      {
-        type: 'divider',
-      },
     ]);
   });
 });