-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agenix: fix installCheckPhase with Nix 2.3 #241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As opposed to e.g. Nix 2.18, Nix 2.3 doesn't try to create a fallback store in $HOME if $NIX_STORE_DIR and $NIX_STATE_DIR aren't writable.
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Mar 3, 2024
- agenix has not been updated (waiting for ryantm/agenix#241). - libgit2_1_5 can be removed (no longer used by cargo-audit). Change-Id: I96c6a1a4175dc4f2a32b9b2e4ed71caa826a9c42 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11077 Tested-by: BuildkiteCI Autosubmit: sterni <[email protected]> Reviewed-by: flokli <[email protected]>
tvlbot
pushed a commit
to tvlfyi/kit
that referenced
this pull request
Mar 3, 2024
- agenix has not been updated (waiting for ryantm/agenix#241). - libgit2_1_5 can be removed (no longer used by cargo-audit). Change-Id: I96c6a1a4175dc4f2a32b9b2e4ed71caa826a9c42 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11077 Tested-by: BuildkiteCI Autosubmit: sterni <[email protected]> Reviewed-by: flokli <[email protected]>
tvlbot
pushed a commit
to tvlfyi/kit
that referenced
this pull request
Mar 17, 2024
- agenix has not been updated (ryantm/agenix#241). - //tvix: regenerate protobuf files - //tvix:clippy: work around rust-lang/rust-clippy#12281 which exclusively causes false positives in our code at the moment. Change-Id: I38d2f4c0e6d1abc92be360b06f58e6d40e7732a3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11127 Reviewed-by: flokli <[email protected]> Tested-by: BuildkiteCI Autosubmit: sterni <[email protected]> Reviewed-by: tazjin <[email protected]>
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Mar 17, 2024
- agenix has not been updated (ryantm/agenix#241). - //tvix: regenerate protobuf files - //tvix:clippy: work around rust-lang/rust-clippy#12281 which exclusively causes false positives in our code at the moment. Change-Id: I38d2f4c0e6d1abc92be360b06f58e6d40e7732a3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11127 Reviewed-by: flokli <[email protected]> Tested-by: BuildkiteCI Autosubmit: sterni <[email protected]> Reviewed-by: tazjin <[email protected]>
tvlbot
pushed a commit
to tvlfyi/kit
that referenced
this pull request
Apr 6, 2024
- agenix has not been updated (ryantm/agenix#241). - Re-enable now fixed dependency of flokli/archeology-ec2. Change-Id: I4e0399e5b5dbaf5e504076e029013f165dd4d191 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11363 Autosubmit: sterni <[email protected]> Tested-by: BuildkiteCI Reviewed-by: flokli <[email protected]>
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Apr 6, 2024
- agenix has not been updated (ryantm/agenix#241). - Re-enable now fixed dependency of flokli/archeology-ec2. Change-Id: I4e0399e5b5dbaf5e504076e029013f165dd4d191 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11363 Autosubmit: sterni <[email protected]> Tested-by: BuildkiteCI Reviewed-by: flokli <[email protected]>
n8henrie
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I can confirm it resolves #248
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Jun 8, 2024
* agenix has not been updated (ryantm/agenix#241). * wasm-bindgen bumped to 0.2.92 in Rust WASM projects * 3p/lisp: port lispPackages from stable channel The Lisp package set we are using (`pkgs.lispPackages`) is the "old old" package set, whereas we were supposed to have been using `pkgs.lispPackages_new` (which is the "old new" package set). Either way we missed that train, and now there's a "new new" package set, but with a twist: Lisp packages in nixpkgs are now tied to their compilers, so the most generic way to access them seems to be from `pkgs.sbclPackages`. Switching to the packages from the "new new" package set doesn't work: Lots of stuff stops building if we just switch the sources over, and not everything is trivially fixable. For now we stay on the lispPackages from the stable channel. We need to look into the migration later. Or rewrite panettone. * tvix: update generated protobuf files * 3p/nixpkgs: pick trunk from stable channel; newer versions try to read files and do network I/O during build, but don't print enough details in error messages to figure out why. * 3p/overlays: remove tdlib override (nixpkgs is currently new enough) * 3p/overlays: override telega.el sources while updates are lagging in nixpkgs * users/flokli/ipu6-softisp: update firmware paths, which NixOS now stores zstd-compressed. Change-Id: I5a7a6c8b5d0688461bca92b9e6d654356d3a1cf1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11711 Tested-by: BuildkiteCI Reviewed-by: flokli <[email protected]> Reviewed-by: tazjin <[email protected]>
tvlbot
pushed a commit
to tvlfyi/kit
that referenced
this pull request
Jun 8, 2024
* agenix has not been updated (ryantm/agenix#241). * wasm-bindgen bumped to 0.2.92 in Rust WASM projects * 3p/lisp: port lispPackages from stable channel The Lisp package set we are using (`pkgs.lispPackages`) is the "old old" package set, whereas we were supposed to have been using `pkgs.lispPackages_new` (which is the "old new" package set). Either way we missed that train, and now there's a "new new" package set, but with a twist: Lisp packages in nixpkgs are now tied to their compilers, so the most generic way to access them seems to be from `pkgs.sbclPackages`. Switching to the packages from the "new new" package set doesn't work: Lots of stuff stops building if we just switch the sources over, and not everything is trivially fixable. For now we stay on the lispPackages from the stable channel. We need to look into the migration later. Or rewrite panettone. * tvix: update generated protobuf files * 3p/nixpkgs: pick trunk from stable channel; newer versions try to read files and do network I/O during build, but don't print enough details in error messages to figure out why. * 3p/overlays: remove tdlib override (nixpkgs is currently new enough) * 3p/overlays: override telega.el sources while updates are lagging in nixpkgs * users/flokli/ipu6-softisp: update firmware paths, which NixOS now stores zstd-compressed. Change-Id: I5a7a6c8b5d0688461bca92b9e6d654356d3a1cf1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11711 Tested-by: BuildkiteCI Reviewed-by: flokli <[email protected]> Reviewed-by: tazjin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opposed to e.g. Nix 2.18, Nix 2.3 doesn't try to create a fallback store in $HOME if $NIX_STORE_DIR and $NIX_STATE_DIR aren't writable.