Remove import for NixOS/HM modules #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `files` on a NixOS option in the `nix repl` it fails to follow the attribute of agenix module. Discussing with @roberth has explained that this is a "common bug" on account of mis-using the `import` for modules. From what I understand, the `import` statement brings it into the current context so you lose the attribute of where it's defined. Here is what I currently see: ``` nix-repl> options.age.ageBin.files [ "/nix/store/8kpmdb63f5i9mwdyirqki7hvvglgy1va-source/machines/nyx/configuration.nix" ] ``` After this change, the value in agenix is reported instead. ``` ❯ nix repl --extra-experimental-features 'flakes repl-flake' \ --override-input agenix /home/fmzakari/code/github.com/ryantm/agenix . nix-repl> options.age.ageBin.files [ "/nix/store/99gc8rhgw43k201k34pshcsygdvbhmpy-source/modules/age.nix" ] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
fileson a NixOS option in thenix replit fails to follow the attribute of agenix module.Discussing with @roberth has explained that this is a "common bug" on account of mis-using the
importfor modules.From what I understand, the
importstatement brings it into the current context so you lose the attribute of where it's defined.Here is what I currently see:
After this change, the value in agenix is reported instead.