Version 3.1.1

CHANGELOG.md

@@ -2,13 +2,22 @@
 
 All notable changes to the **FlexSeedScheme** (FSS) package are documented here.
 
+## 3.1.1
+
+**July 13, 2024**
+
+**CHORE**
+
+* FIX the pub score.
+* Update readme.
+
 ## 3.1.1-dev.1
 
 **July 12, 2024**
 
 **CHORE**
 
-* Experiment to find and remove references from the package to deprecated properties for scoring purposes. The deprecated colors are **NOT** used anymore, but pub's pana analyzer still complains. It happily ignores the "allow usage of self-deprecated members" setting. It also complains about references used in doc comments. This is the first attempt to find and fixe all things it complains about.
+* Experiment to find and remove references from the package to deprecated properties for scoring purposes. The deprecated colors are **NOT** used anymore, but pub's pana analyzer still complains. It happily ignores the "allow usage of self-deprecated members" setting. It also complains about references used in doc comments. This is the first attempt to find and fix all things it complains about.
 
 ## 3.1.0
 

analysis_options.yaml

@@ -57,10 +57,6 @@ analyzer:
     # Invocation of equality operator == with references of unrelated types.
     unrelated_type_equality_checks: warning
 
-    # Allow self-reference to deprecated members. This is done because otherwise we have
-    # to annotate every member in every test, assert, etc. when we deprecate something.
-    # deprecated_member_use_from_same_package: ignore
-
     # DON'T assign new values to parameters of methods or functions.
     #
     # https://dart.dev/tools/linter-rules/parameter_assignments.html
@@ -165,8 +161,7 @@ linter:
     # look into what type an object is.
     #
     # We felt the above long explanation was warranted as a reminder. Keeping the rule listed here
-    # and the setting below, in order to easily turn it OFF permanently some day, or in some
-    # projects.
+    # and the setting below. Maybe we turn it OFF permanently some day, or in some projects.
     #
     # Other known linters use:
     #
@@ -196,10 +191,10 @@ linter:
     # Flutter repo now also prefers relative imports over package imports, so that is
     # another reason to use that.
     #
-    # Use what you prefer, but you have to be consistent though, since mixing and matching can
-    # cause issues as the same file imported with the different options are considered to be
+    # Use what you prefer, but be consistent. Mixing and matching can
+    # cause issues if the same file is imported with the different options are considered to be
     # different libs and code, even if it is the same file. This may impact the functionality
-    # of e.g. singletons, service locators and increase code size.
+    # of e.g., singletons, service locators and increase code size.
     #
     # When you refactor and move folders with a lot of code in them, that other code depends
     # on for imports via relative imports, then they get messed up by Flutter IDEs
@@ -222,8 +217,9 @@ linter:
     #
     # https://dart.dev/tools/linter-rules/avoid_annotating_with_dynamic.html
     #
-    # Violates Effective Dart "PREFER annotating with dynamic instead of letting inference fail", it
-    # also conflicts with strong mode disabling `implicit-dynamic`. Turning it OFF.
+    # Violates Effective Dart "PREFER annotating with dynamic instead of letting inference fail".
+    # This rule also conflicts with strong mode disabling `implicit-dynamic`.
+    # Turning it OFF.
     #
     # Other known linters use:
     #
@@ -479,7 +475,7 @@ linter:
     # package in which they are declared.
     #
     # RydMike: In packages and especially in public packages, it is often useful to deprecate a
-    # member, but keep it available and functional until the deprecated member is completley
+    # member, but keep it available and functional until the deprecated member is completely
     # removed. We thus need to reference it in code and doc comments.
     #
     # Other known linters use:
@@ -567,7 +563,7 @@ linter:
     # https://dart.dev/tools/linter-rules/lines_longer_than_80_chars.html
     #
     # Using this rule will sometimes force a line of 81 characters to be split in two.
-    # As long as we try to respect the 80-character limit, going slightly above is fine.
+    # As long as we try to respect the 80-character limit going slightly above is fine.
     #
     # For packages, keep this rule enabled though, because the pub.dev dart format check will
     # penalize package points if it does not adhere to strict Dart format rules, which
@@ -652,7 +648,7 @@ linter:
     # RydMike        disabled : https://gist.github.com/rydmike/fdb53ddd933c37d20e6f3188a936cd4c
     omit_local_variable_types: false
 
-    # PREFER asserts with a message string.
+    # PREFER using asserts with a message string.
     #
     # https://dart.dev/tools/linter-rules/prefer_asserts_with_message.html
     #
@@ -721,7 +717,7 @@ linter:
     #
     # This rule is mostly about what style you want to use and enforce, if any.
     # It of course conflicts with rule:
-    # `prefer_single_quotes` : "DO use single quotes where they wouldn't require additional escapes."
+    # `prefer_single_quotes`: "DO use single quotes where they wouldn't require additional escapes."
     # https://dart.dev/tools/linter-rules/prefer_single_quotes.html
     #
     # For us single quotes are easier to type. On our ISO keyboards it is next to Enter key, and
@@ -778,13 +774,13 @@ linter:
     # avoid accidental reassignments.
     #
     # Certainly a good idea in many cases. There seems to be one "small" false positive issue with it.
-    # Lint is triggered by final constructor properties, e.g. in
+    # Lint is triggered by final constructor properties, e.g., in
     # `final int i;` the parameter `this.i` is not also final, which is not really needed
     # since the property is final. However, this triggers the rule unnecessarily. We had to
     # turn OFF this rule due to it.
     #
     # We turned OFF the rule. In a test project, after we cleaned up all that could be after Flutter 2.5 upgrade.
-    # There were still 150 positives from the rule, from above issue. So after having it on and doing cleanup
+    # There were still 150 positives from the rule, from the above issue. So after having it on and doing cleanup
     # where it could be used, we turned off the rule for now. Pity, it is a useful and nice rule otherwise.
     #
     # Other known linters use:

example/lib/core/constants/app_data.dart

@@ -6,15 +6,13 @@ import 'package:flutter/material.dart';
 /// classes that serves your application's usage. For these examples I
 /// put them all in the same class, except the colors that are in their
 /// own class.
-class AppData {
-  AppData._();
-  // Info about the app.
-
-  // Returns the title of the MaterialApp. Used to set title on pages to
-  // same one that is defined in each example as its app name. Handy as we only
-  // need to update in one place, where it belongs and no need to put it as
-  // a const somewhere and no need to pass it around via a title prop either.
-  // Also used in the About box as app name.
+sealed class AppData {
+  // Returns the title of the MaterialApp.
+  //
+  // Used to set title on pages to same one that is defined in each example
+  // as its app name. Handy as we only need to update in one place, where it
+  // belongs and no need to put it as a const somewhere and no need to pass it
+  // around via a title prop either. Also used in the About box as app name.
   static String title(BuildContext context) =>
       (context as Element).findAncestorWidgetOfExactType<MaterialApp>()!.title;
 
@@ -27,7 +25,7 @@ class AppData {
   // build numbers.
   static const String versionMajor = '3';
   static const String versionMinor = '1';
-  static const String versionPatch = '1-dev.1';
+  static const String versionPatch = '1';
   static const String versionBuild = '01';
   static const String version = '$versionMajor.$versionMinor.$versionPatch '
       'Build-$versionBuild';

example/lib/theme/controllers/theme_controller.dart

@@ -17,7 +17,7 @@ class ThemeController with ChangeNotifier {
     if (notify) notifyListeners();
   }
 
-  bool _showColorValue = true;
+  bool _showColorValue = false;
   bool get showColorValue => _showColorValue;
   void setShowColorValue(bool? value, [bool notify = true]) {
     if (value == null) return;

example/pubspec.lock

@@ -71,7 +71,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "3.1.1-dev.1"
+    version: "3.1.1"
   flutter:
     dependency: "direct main"
     description: flutter

example/pubspec.yaml

@@ -1,6 +1,6 @@
 name: flex_seed_scheme_example
 description: Example that demonstrate how to use the FlexSeedScheme package.
-version: 3.1.1-dev.1
+version: 3.1.1
 publish_to: 'none'
 environment:
   sdk: '>=3.0.0 <4.0.0'

pubspec.yaml

@@ -1,6 +1,6 @@
 name: flex_seed_scheme
 description: A more flexible and powerful version of Flutter's ColorScheme.fromSeed. Use multiple seed colors, custom chroma and tone mapping.
-version: 3.1.1-dev.1
+version: 3.1.1
 homepage: https://github.com/rydmike/flex_seed_scheme
 repository: https://github.com/rydmike/flex_seed_scheme
 issue_tracker: https://github.com/rydmike/flex_seed_scheme/issues
@@ -32,8 +32,7 @@ environment:
   flutter: '>=3.22.0'
 
 dependencies:
-  # Used by mcu: tonal_palette.dart
-  # Require at least 1.15.0, the first stable version for null-safety.
+  # Used by mcu: tonal_palette.dart, require at least 1.18.0.
   # https://pub.dev/packages/collection
   collection: ^1.18.0
 
@@ -46,7 +45,7 @@ dependencies:
   # Flutter does not expose the "@internal" annotation via foundation, to use it we need to import the package.
   # Version 1.9.1 is first with updated SDK constraints to >=2.12.0 <4.0.0.
   # https://pub.dev/packages/meta
-  meta: ^1.8.0
+  meta: ^1.9.1
 
 dev_dependencies: