Update protocol core to fix SKV4093GL connection problem #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKV4093GL (aka STYTJ01ZHM aka dreame.vacuum.mc1808) connection problem was referenced first in #1066, later in #1086, and the working (as for me) fix was provided by @anonymous-one. However @rytilahti [suggested](#1066 (comment)) another way to fix this problem, I'd like to request to accept @anonymous-one's solution of the problem as the fastest one.
|
As I mentioned earlier, I don't feel good about changing the id generation on that level as that might introduce problems on other devices that are currently working just fine. One possible solution would be adding an interface to allow device implementations to define their own id generation logic, but it feels kludgy, too. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SKV4093GL (aka STYTJ01ZHM aka dreame.vacuum.mc1808) connection problem was referenced first in #1066, later in #1086, and the working (as for me) fix was provided by @anonymous-one. Although @rytilahti suggested another way to fix this problem, I'd like to request to accept @anonymous-one's solution of the problem as the fastest one.