Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve philips.light.mono1 support #1269

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Improve philips.light.mono1 support #1269

wants to merge 1 commit into from

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Dec 20, 2021

The device is supported of the HA core by using the properties of the philips.light.bulb which isn't perfect. The PR improves the situation a bit but has still some gaps.

@syssi syssi marked this pull request as draft December 20, 2021 21:09
rytilahti
rytilahti approved these changes Jan 4, 2022
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay @syssi and glad to see you around!

edit: I noticed that this is marked as a draft, so I'm not directly merging it in case you want to adjust something. Feel free to merge if no changes are required.

@rytilahti
Copy link
Owner

@syssi should this get included in the next release?

@rytilahti rytilahti added this to the 0.5.12 milestone Jul 7, 2022
@rytilahti rytilahti modified the milestones: 0.5.12, 0.5.13 Jul 18, 2022
@rytilahti rytilahti removed this from the 0.5.13 milestone Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syssi @rytilahti