Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null-valued ins and outs for miotaction #1943

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

rytilahti
Copy link
Owner

This PR parses null-valued ins & outs for miotactions as empty lists to avoid crashing on unexpected schemas.

Example seen in the wild (roidmi.vacuum.v66):

{
    "iid": 3,
    "type": "urn:miot-spec-v2:action:start-room-sweep:00002826:roidmi-v66:1",
    "description": "Start Room Sweep",
    "in": [
        9
    ],
    "out": null
}

Fixes #1942

@rytilahti rytilahti added the bug label Jun 20, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (d517905) to head (cdd4719).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1943   +/-   ##
=======================================
  Coverage   81.62%   81.63%           
=======================================
  Files         197      197           
  Lines       19127    19134    +7     
  Branches     4206     4209    +3     
=======================================
+ Hits        15613    15620    +7     
  Misses       3216     3216           
  Partials      298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti merged commit e88159f into master Oct 26, 2024
23 of 25 checks passed
@rytilahti rytilahti deleted the fix/null_action_fields branch October 26, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roidmi Eva (roidmi.vacuum.v66) with genericmiot
1 participant