Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing and writing #12

Merged
merged 16 commits into from
Aug 6, 2024
Merged

Add parsing and writing #12

merged 16 commits into from
Aug 6, 2024

Conversation

yitzchak
Copy link
Member

No description provided.

@yitzchak yitzchak marked this pull request as ready for review July 22, 2024 14:52
@yitzchak
Copy link
Member Author

@paulapatience There are few issues left to iron out here in addition to whatever results from your review.

First, the parse-digits, read-digits, compose-digits and write-digits are all currently generic, but I am wondering if we should remove the client and make those regular exported "utility" functions since the individual number parsers call those with various parameters depending on the parsing branch.

Second, the write-number and compose-number interface is bogus. I haven't worked on that yet so it is probably not worth reviewing yet since I'll probably revamp all of it. I'm not sure I'll be able to get there immediately, but I'd like to have a low-level generic write-number/compose-number and a high level function in quaviver/string that is basically equivalent to FORMAT but with C, CL, JSON, etc. clients.

@yitzchak yitzchak force-pushed the parse branch 13 times, most recently from 8492e8f to cea17f4 Compare July 25, 2024 12:34
@yitzchak yitzchak force-pushed the parse branch 5 times, most recently from f2c52d2 to af6e86d Compare July 27, 2024 18:09
@yitzchak yitzchak changed the title Add parsing Add parsing and writing Jul 30, 2024
@yitzchak yitzchak force-pushed the parse branch 4 times, most recently from 90e80c4 to e424f30 Compare August 1, 2024 13:28
@yitzchak yitzchak merged commit 0dc8638 into main Aug 6, 2024
6 checks passed
@yitzchak yitzchak deleted the parse branch August 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant