-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parsing and writing #12
Conversation
@paulapatience There are few issues left to iron out here in addition to whatever results from your review. First, the parse-digits, read-digits, compose-digits and write-digits are all currently generic, but I am wondering if we should remove the client and make those regular exported "utility" functions since the individual number parsers call those with various parameters depending on the parsing branch. Second, the write-number and compose-number interface is bogus. I haven't worked on that yet so it is probably not worth reviewing yet since I'll probably revamp all of it. I'm not sure I'll be able to get there immediately, but I'd like to have a low-level generic write-number/compose-number and a high level function in quaviver/string that is basically equivalent to FORMAT but with C, CL, JSON, etc. clients. |
8492e8f
to
cea17f4
Compare
f2c52d2
to
af6e86d
Compare
90e80c4
to
e424f30
Compare
No description provided.