Added escape listener for closing the full screen popup #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amritk
changed the title
s-yadav
requested changes
Jun 7, 2019
| e.preventDefault(); | ||
| } | ||
| } | ||
| document.addEventListener('keyup', this._events.escapeListener); |
There was a problem hiding this comment.
use assignEvent from the util, which returns a method to remove event.
You can do
this.__events.onEscape = assignEvent(document, 'keyup', this._events.escapeListener);and in hide method you can just call.
this.__events.onEscape();| @@ -101,6 +104,14 @@ function (_ImageViewer) { | |||
| this.load(imageSrc, hiResImageSrc); | |||
| } // handle window resize | |||
|
|
|||
| // escape listener | |||
| this._events.escapeListener = (e) => { | |||
There was a problem hiding this comment.
this._events holds the removeListener methods, don't add listener there. See below. This will give error when you do viewer.destroy()
| @@ -69,6 +69,9 @@ function (_ImageViewer) { | |||
| display: 'none' | |||
| }); // enable scroll | |||
|
|
|||
| // escape listener | |||
| document.removeEventListener('keyup', _this._events.escapeListener); | |||
There was a problem hiding this comment.
This all changes should be on source file. Lib is the generated file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we want to make this an option, or just on by default?