feat(SwitchTeam): add of bomb removal on team switch #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justgo97
reviewed
Nov 15, 2023
regamedll/dlls/player.cpp
Outdated
| m_bHasC4 = false; | ||
| pev->body = 0; | ||
| SetBombIcon(FALSE); | ||
| SetProgressBarTime(0); |
There was a problem hiding this comment.
pPlayer->m_bHasC4 = false;
pPlayer->pev->body = 0;
pPlayer->SetBombIcon(FALSE);
pPlayer->SetProgressBarTime(0);
You probably can remove these 4 lines since RemovePlayerItemEx already has them. also the bRemoveAmmo param of RemovePlayerItemEx can be set to false since we are dealing with an item that has no ammo.
There was a problem hiding this comment.
Thank you for the feedback! I'll remove the suggested 4 lines. Regarding bRemoveAmmo, I'll keep it as true because in certain non-standard scenarios or mods, there might be a possibility of having ammo reserves for the bomb. I've tested this case.
s1lentq
force-pushed
the
master
branch
4 times, most recently
from
a363cba
to
79cfd71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.