Add GetWeaponRatio for readability in TakeDamage forward

[justgo97]

No behavior changes introduced.

[Vaqtincha]

#600

more functionality and practicality

[justgo97]

#600

more functionality and practicality

Yes your PR has more functionality, this PR doesn't contradict yours and it's easy to review, you can still submit your changes if this one gets merged.

[Vaqtincha]

@justgo97 take it (with the latest changes) you can add it to this pr

[justgo97]

@justgo97 take it (with the latest changes) you can add it to this pr

Maybe in another PR if this one gets passed, I want to see first if this repo is still active and accepts changes like this, I have more changes not related to this function in my local fork.

[Vaqtincha]

@justgo97 Do not misunderstand me. It's better to do such things perfectly. Then changing it will be problematic due to backward compatibility

[dystopm]

A few recommendations to make this even better:

• add more parameters to the function, like: victim, inflictor, attacker, damagetype, weaponent - to enrich API consumption
• rename function to GetWeaponArmorRatio
• change every magic number into a named constant, and write it to weapons.h
• add an API-only behaviour that retrieves armorratio from a CCSPlayerWeapon member (and init their values in the constant ones), so coders can easily alter armor ratio based on entities

[justgo97]

A few recommendations to make this even better:

• add more parameters to the function, like: victim, inflictor, attacker, damagetype, weaponent - to enrich API consumption
• rename function to GetWeaponArmorRatio
• change every magic number into a named constant, and write it to weapons.h
• add an API-only behaviour that retrieves armorratio from a CCSPlayerWeapon member (and init their values in the constant ones), so coders can easily alter armor ratio based on entities

Feel free to open another PR with those changes, I'm just doing small changes for now.