Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter for unfocusable windows #90

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

9ary
Copy link
Contributor

@9ary 9ary commented Sep 15, 2024

Fixes #67.

README.md Outdated Show resolved Hide resolved
@okuuva
Copy link
Contributor

okuuva commented Sep 16, 2024

Also fixes #86 .

@9ary 9ary force-pushed the unfocusable-windows branch from 674a013 to 76e3846 Compare September 16, 2024 07:59
@farzadmf
Copy link

farzadmf commented Jan 8, 2025

Thank you @9ary for the fix

Not sure how the two issues are resolved as I kept having issues.

Given that it's been 4 months here, I'm not very optimistic for this to be merged, and I switched to using your fork

@9ary
Copy link
Contributor Author

9ary commented Jan 8, 2025

@farzadmf what issues?

Please keep in mind that I'm not planning to maintain my fork any more than I have to. It is rather unfortunate that this seems abandoned though.

@farzadmf
Copy link

farzadmf commented Jan 8, 2025

@farzadmf what issues?

Not sure what happened, but recently, I've been getting errors right and left when using the window-picker with neo-tree. I think it was running out of "characters" because of all the windows it detected, which was news to me that vim.api.nvim_tabpage_list_wins(0) returns quite a few window IDs even when I open an "empty" Neovim! 😮

I'm not planning to maintain my fork any more than I have to

Totally makes sense; I wanted to create my own fork but then saw that you already have everything, so I used it.

this seems abandoned

Yeah, that's my thought as well, so I think as long as you don't delete your repo, even if you don't add anything, everything is good 🙂

@s1n7ax s1n7ax merged commit 1656a0a into s1n7ax:main Jan 9, 2025
@s1n7ax
Copy link
Owner

s1n7ax commented Jan 9, 2025

@9ary Thanks. Sorry for the delay. I only saw this now after someone added a new comment

@9ary
Copy link
Contributor Author

9ary commented Jan 9, 2025

Thank you @s1n7ax! Would you please look at/merge #91 as well? That's a trivial fix for a visual issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treesitter-context gets picked up on
4 participants