commit.

s7monk · Jan 24, 2024 · 1a281e4 · 1a281e4
1 parent 671f262
commit 1a281e4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/...n-web-server/src/main/java/org/apache/paimon/web/server/controller/CatalogController.java b/...n-web-server/src/main/java/org/apache/paimon/web/server/controller/CatalogController.java
@@ -56,7 +56,11 @@ public CatalogController(CatalogService catalogService) {
     @PostMapping("/create")
     public R<Void> createCatalog(@RequestBody CatalogDTO catalogDTO) {
         try {
-            return catalogService.createCatalog(catalogDTO);
+            if (catalogService.checkCatalogNameUnique(catalogDTO)) {
+                return R.failed(Status.CATALOG_NAME_IS_EXIST, catalogDTO.getName());
+            }
+            catalogService.createCatalog(catalogDTO);
+            return R.succeed();
         } catch (Exception e) {
             log.error("Exception with creating catalog.", e);
             return R.failed(Status.CATALOG_CREATE_ERROR);

diff --git a/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/CatalogService.java b/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/CatalogService.java
@@ -41,5 +41,5 @@ public interface CatalogService extends IService<CatalogInfo> {
      * @param catalogDTO catalog for the catalog.
      * @return The created catalog.
      */
-    R<Void> createCatalog(CatalogDTO catalogDTO);
+    void createCatalog(CatalogDTO catalogDTO);
 }
diff --git a/...eb-server/src/main/java/org/apache/paimon/web/server/service/impl/CatalogServiceImpl.java b/...eb-server/src/main/java/org/apache/paimon/web/server/service/impl/CatalogServiceImpl.java
@@ -45,11 +45,7 @@ public boolean checkCatalogNameUnique(CatalogDTO catalogDTO) {
     }
 
     @Override
-    public R<Void> createCatalog(CatalogDTO catalogDTO) {
-        if (checkCatalogNameUnique(catalogDTO)) {
-            return R.failed(Status.CATALOG_NAME_IS_EXIST, catalogDTO.getName());
-        }
-
+    public void createCatalog(CatalogDTO catalogDTO) {
         if (catalogDTO.getType().equalsIgnoreCase(CatalogMode.FILESYSTEM.getMode())) {
             PaimonServiceFactory.createFileSystemCatalogService(
                     catalogDTO.getName(), catalogDTO.getWarehouse(), catalogDTO.getOptions());