Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix build failing due to old (and deprecated) packages #630

Merged
merged 3 commits into from
Aug 27, 2023

Conversation

AhsanAyaz
Copy link
Collaborator

Description

Fixes #611, #623

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-folio ❌ Failed (Inspect) Aug 22, 2023 9:06am

Copy link
Owner

@saadpasta saadpasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This won't fix the CI I guess but better to be on the latest package

@saadpasta saadpasta merged commit 4672e2a into saadpasta:master Aug 27, 2023
1 of 2 checks passed
@AhsanAyaz AhsanAyaz deleted the fix/build-failing branch August 28, 2023 08:57
Mehranmzn pushed a commit to Mehranmzn/mehranmzn.github.io that referenced this pull request Sep 13, 2024
…pasta#630)

* fix(ci): fix build failing due to old (and deprecated) packages

* docs(readme): update lottie-react references

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Actions Deploy
2 participants