Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release major version 5 #1415

Open
phil-davis opened this issue Sep 11, 2022 · 9 comments
Open

Release major version 5 #1415

phil-davis opened this issue Sep 11, 2022 · 9 comments
Assignees

Comments

@phil-davis
Copy link
Contributor

which will support PHP 7.4 8.0 8.1 8.2 and have type declarations on parameters and return values etc as far as possible with features available in PHP 7.4.

If possible, increase the phpstan level to 6. That requires adding a lot of parameters and return type detail in PHPdoc (specially of the shape of arrays. I will try adjusting a few things and then report how it goes, and how big a job it seems.

@phil-davis phil-davis self-assigned this Sep 11, 2022
@phil-davis
Copy link
Contributor Author

Blocked by sabre-io/vobject#588 - I need to work on that issue firts and get sabre/vobject 5.0.0 released. sabre/dav has a dependency on that.

@phil-davis
Copy link
Contributor Author

Status of sabre components as at 2022-09-11

Done:
cache - 2.0.0 (2022-08-23)
event - 6.0.0 (2022-08-29)
http - 6.0.0 (2022-08-31)
uri - 2.3.1 (2022-08-30) major version was not needed
xml - 3.0.0 (2022-08-17)

ToDo:
vobject - sabre-io/vobject#588
dav - this issue

@BinaryKitten
Copy link

hi - can i politely ask as to the status of the updates?

@phil-davis
Copy link
Contributor Author

hi - can i politely ask as to the status of the updates?

I was making lots of progress, then got going on vobject sabre-io/vobject#591 and it needs "a lot" (tm) of specifying types through the code. I have not got back to it for the last 3 months.

sabre-io/vobject#591 (comment)

@BinaryKitten
Copy link

I was making lots of progress, then got going on vobject sabre-io/vobject#591 and it needs "a lot" (tm) of specifying types through the code. I have not got back to it for the last 3 months.

sabre-io/vobject#591 (comment)

Is there anything anyone can do to help?

@DeepDiver1975
Copy link
Member

Once #1497 is merged we can create a 4.x branch and move towards 5.x on master .... objections @phil-davis @staabm ?

@phil-davis
Copy link
Contributor Author

yes, get as many little fixes and tweaks released in the 4.* series and then we can branch it, and do real work in master towards v5.

@staabm
Copy link
Member

staabm commented Nov 9, 2023

sounds good to me

@staabm
Copy link
Member

staabm commented Nov 14, 2023

@phil-davis if you think its helpful, I can infer parameter/return types with rector for most stuff, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants