-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use php7.4 as minimum #1502
Conversation
cc5c5b7
to
11fca95
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1502 +/- ##
============================================
- Coverage 97.32% 97.22% -0.11%
+ Complexity 2833 2831 -2
============================================
Files 175 175
Lines 9425 9010 -415
============================================
- Hits 9173 8760 -413
+ Misses 252 250 -2 ☔ View full report in Codecov by Sentry. |
02668f8
to
9933736
Compare
@DeepDiver1975 there were 1807 unit tests running - for exampe https://github.com/sabre-io/dav/actions/runs/6862503131/job/18660341581 Maybe renaming various test file to |
I will look into this. |
9933736
to
9296cf2
Compare
@phil-davis we have now 1640 tests. Previously test within sabre/http were executed as well - but they no longer exist in the composer package. This is fine form my pov as it is no the job of sabre/dav to run sabre/http tests |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will merge and we can progress from here towards a major version with type declarations etc. |
refs #1415