Rework handling of values that are not recognized

This will remove the necesity to calculate the class name twice in immediate succession should the declared valuetype not be set.
sabre-io · Oct 22, 2024 · 4761ca2 · 4761ca2
1 parent 2f24ce1
commit 4761ca2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/Document.php b/lib/Document.php
@@ -206,8 +206,8 @@ public function createProperty($name, $value = null, ?array $parameters = null,
         //  parameter need not be specified.  However, if the property's
         //  default value type is overridden by some other allowable value
         //  type, then this parameter MUST be specified.
-        if (isset($parameters['VALUE'])) {
-            $class = $this->getClassNameForPropertyValue($parameters['VALUE']);
+        if (!$valueType) {
+            $valueType = $parameters['VALUE'] ?? null;
         }
 
         if ($valueType) {