Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more Exchange timezone aliases (#464) #476

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alecpl
Copy link
Contributor

@alecpl alecpl commented Nov 13, 2019

Fixes #464

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #476 (b2d082b) into master (ebe9748) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #476      +/-   ##
============================================
+ Coverage     98.68%   98.73%   +0.04%     
+ Complexity     1796     1759      -37     
============================================
  Files            65       66       +1     
  Lines          4272     4279       +7     
============================================
+ Hits           4216     4225       +9     
+ Misses           56       54       -2     
Impacted Files Coverage Δ
lib/timezonedata/exchangezones.php 100.00% <ø> (ø)
lib/Property/Boolean.php 53.84% <0.00%> (-4.49%) ⬇️
lib/Parser/Json.php 96.72% <0.00%> (-0.11%) ⬇️
lib/Component/VCalendar.php 94.59% <0.00%> (-0.04%) ⬇️
lib/Cli.php 98.02% <0.00%> (-0.02%) ⬇️
lib/FreeBusyGenerator.php 98.10% <0.00%> (-0.01%) ⬇️
lib/Property/Text.php 99.12% <0.00%> (-0.01%) ⬇️
lib/Parameter.php 99.20% <0.00%> (-0.01%) ⬇️
lib/Parser/MimeDir.php 99.54% <0.00%> (-0.01%) ⬇️
lib/Node.php 100.00% <0.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe9748...b2d082b. Read the comment docs.

@evert
Copy link
Member

evert commented Nov 13, 2019

The list of aliases is based on official microsoft sources. Do you have a source for this?

@alecpl
Copy link
Contributor Author

alecpl commented Nov 13, 2019

The linked ticket contains a real example. So called "WebEX invitation" contains PRODID:-//Microsoft Corporation//Outlook 10.0 MIMEDIR//EN.

I don't have another source.

@evert
Copy link
Member

evert commented Nov 13, 2019

Then I would discourage merging this as-is. It's not really possible to tell if that file was generated by exchange, it's just as likely that something modified it. All the files added to these aliases are all generated based on sources from real vendors, so at the very least it's sloppy to add it to the aliases file for exchange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Eastern Time" to timezone mappings
2 participants