Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPstan level 2 #498

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

PHPstan level 2 #498

wants to merge 9 commits into from

Conversation

JeroenVanOort
Copy link
Contributor

There was no other way to make this happen than to make a custom PHPStan extension.

@codecov
Copy link

codecov bot commented Feb 2, 2020

Codecov Report

Merging #498 into master will increase coverage by 0.35%.
The diff coverage is 97.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #498      +/-   ##
============================================
+ Coverage     98.33%   98.68%   +0.35%     
- Complexity     1757     1760       +3     
============================================
  Files            67       66       -1     
  Lines          4328     4272      -56     
============================================
- Hits           4256     4216      -40     
+ Misses           72       56      -16
Impacted Files Coverage Δ Complexity Δ
lib/Parameter.php 99.2% <ø> (-0.01%) 81 <0> (ø)
lib/Recur/RDateIterator.php 96.87% <ø> (ø) 14 <0> (ø) ⬇️
lib/Node.php 100% <ø> (ø) 10 <0> (ø) ⬇️
lib/BirthdayCalendarGenerator.php 98.07% <ø> (ø) 18 <0> (ø) ⬇️
lib/Parser/XML/Element/KeyValue.php 84.61% <ø> (ø) 4 <0> (ø) ⬇️
lib/VCardConverter.php 98.92% <ø> (ø) 72 <0> (ø) ⬇️
lib/Recur/EventIterator.php 100% <ø> (ø) 46 <0> (ø) ⬇️
lib/Property/ICalendar/DateTime.php 100% <ø> (ø) 44 <0> (ø) ⬇️
lib/Document.php 100% <100%> (ø) 24 <0> (ø) ⬇️
lib/Component/VCard.php 100% <100%> (ø) 53 <0> (ø) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d529dda...b40b250. Read the comment docs.

lib/Cli.php Outdated Show resolved Hide resolved
@phil-davis
Copy link
Contributor

@JeroenVanOort I merged PR #500 that "standardizes" more CI stuff.
Sorry, now you have conflicts.
Please rebase and resolve...

@phil-davis phil-davis requested review from staabm and evert March 1, 2020 15:48
@phil-davis
Copy link
Contributor

@JeroenVanOort this has been sitting for a while and now has conflicts. Are you able to rebase and resolve them again?

@phil-davis phil-davis self-requested a review February 12, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants