Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PHP 8.4 to CI [4.5] #662

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

phil-davis
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (d13cf26) to head (41dc45e).
Report is 10 commits behind head on 4.5.

Additional details and impacted files
@@            Coverage Diff            @@
##                4.5     #662   +/-   ##
=========================================
  Coverage     98.65%   98.65%           
- Complexity     1907     1930   +23     
=========================================
  Files            71       71           
  Lines          5294     5294           
=========================================
  Hits           5223     5223           
  Misses           71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis
Copy link
Contributor Author

This branch has an old version of phpstan that does not seem to find the code that is deprecated in PHP 8.4
The workflow reports plenty of deprecated things as PHP runs, but phpstan does not fail on any of them.
I will do a manual search.

@cedric-anne
Copy link
Contributor

PHPStan compat with PHP 8.4 has been released recently, you should try to update it and see if it works :)

@phil-davis phil-davis self-assigned this Oct 14, 2024
@phil-davis phil-davis changed the title chore: add PHP 8.4 to CI chore: add PHP 8.4 to CI [4.5] Oct 14, 2024
@phil-davis
Copy link
Contributor Author

Passing now for all supported PHP versions 7.1 to 8.4 so I will merge this.

It does not have the php-cs-fixer nullable_type_declaration rule check that is in master (PR #694 ) because the old php-cs-fixer used here does not do that.

But we do have unit tests running and passing with PHP 8.4 and not reporting any deprecation warnings. So that will be enough for this 4.5 release series.

@phil-davis phil-davis merged commit 7044047 into sabre-io:4.5 Oct 14, 2024
11 checks passed
@phil-davis phil-davis deleted the add-php-8.4-to-ci-for-4.5 branch October 14, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants