Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if event status was changed to cancelled and generate appr… #669

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

fix: check if event status was changed to cancelled and generate appropriate message

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (46bce0e) to head (a2f05dd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #669   +/-   ##
=========================================
  Coverage     98.78%   98.78%           
- Complexity     1874     1875    +1     
=========================================
  Files            71       71           
  Lines          5270     5270           
=========================================
  Hits           5206     5206           
  Misses           64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis
Copy link
Contributor

Thanks for the contribution.
@SebastianKrupinski php-cs-fixer fails because of the new version 3.64.
I have fixed the code-style in PR #672
Please rebase, and add a test to cover the new behavior.

@SebastianKrupinski
Copy link
Contributor Author

Thanks for the contribution. @SebastianKrupinski php-cs-fixer fails because of the new version 3.64. I have fixed the code-style in PR #672 Please rebase, and add a test to cover the new behavior.

Done

@phil-davis phil-davis merged commit 28e191b into sabre-io:master Oct 14, 2024
8 checks passed
@phil-davis
Copy link
Contributor

Backported to the 4.5 branch in PR #695

@phil-davis
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski deleted the fix-status-cancelled branch October 14, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants