Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.5] refactor: Replace dirname(__FILE__) with __DIR__ #693

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

phil-davis
Copy link
Contributor

Backport #675 from master, just to keep the test code as much in sync as possible.

@phil-davis phil-davis self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (ccbf597) to head (d13cf26).
Report is 3 commits behind head on 4.5.

Additional details and impacted files
@@            Coverage Diff            @@
##                4.5     #693   +/-   ##
=========================================
  Coverage     98.65%   98.65%           
  Complexity     1907     1907           
=========================================
  Files            71       71           
  Lines          5294     5294           
=========================================
  Hits           5223     5223           
  Misses           71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis phil-davis merged commit 78727aa into sabre-io:4.5 Oct 14, 2024
10 checks passed
@phil-davis phil-davis deleted the refactor/dirname-to-dir-4.5 branch October 14, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants