Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to load meta data #123

Merged
merged 2 commits into from
Apr 11, 2024
Merged

added option to load meta data #123

merged 2 commits into from
Apr 11, 2024

Conversation

smuellerd
Copy link
Member

Added a parameter to load the additional meta data (resources, PMIDs, sign decision, TF class) for CollecTRI.

Copy link
Member

@deeenes deeenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Shouldn't we put the first part into OmnipathR, so there is an easy option to extract these columns for those who don't use DecoupleR?

@@ -104,6 +106,7 @@ get_collectri <- function(organism='human', split_complexes=FALSE, ...){
organism = organism,
genesymbol=TRUE,
loops=TRUE,
extra_attrs = TRUE,
...
),
error = function(e){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fallback won't have the extra_attrs column (though we can include it in the future). It raises a warning, so the user will be aware. Optionally we can handle the rare case when this happens with load_meta = TRUE.

"mor" = weight,
)

if (!load_meta){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit too much duplication, only little differences between the two branches

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I think we can merge this :)

@deeenes deeenes merged commit 8716d1a into saezlab:master Apr 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants