Type Locking Service responses as "raw" #2068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sample implementation for #1731.
Summary
We validate API responses on the domain layer, but directly assign the type in the datasources. This means that the response types are not necessarily correct.
Using the Locking Service as an example, this type all responses as "raw". These responses can therefore not be used directly unless they are validated.
By returning the API response directly in the
CommunityRepository
, you can see a type error that demonstrates this:Changes
Raw
utility type