Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe and ERC-7579 #500

Merged
merged 9 commits into from
Jun 14, 2024
Merged

Safe and ERC-7579 #500

merged 9 commits into from
Jun 14, 2024

Conversation

tanay1337
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jun 10, 2024

Branch preview

✅ Deployed successfully in branch deployment:

https://7579--docs.review.5afe.dev

Copy link

github-actions bot commented Jun 10, 2024

Overall readability score: 54.37 (🔴 -1.12)

File Readability
7579-safe.mdx 32.3 (-)
developer-tooling.mdx 22.19 (-)
overview.mdx 16.98 (-)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
7579-safe.mdx 32.3 35.68 13.68 17.1 16.65 8.87
  - - - - - -
developer-tooling.mdx 22.19 23.02 15.76 16.1 18.15 10.05
  - - - - - -
overview.mdx 16.98 11.01 15.36 20.2 19 9.04
  - - - - - -

Averages:

  Readability FRE GF ARI CLI DCRS
Average 54.37 47.83 11.03 12.99 12.63 7.67
  🔴 -1.12 🔴 -0.9 🔴 -0.14 🔴 -0.18 🔴 -0.19 🔴 -0.06
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@tanay1337 tanay1337 requested review from louis-md and removed request for louis-md June 10, 2024 10:29
@nlordell
Copy link
Collaborator

nlordell commented Jun 12, 2024

I just realized I gave some inaccurate information in our 1:1 today: namely, the 7579 registry (while it can be swapped out for any other registry) is specific to the Safe 7579 adapter module and not part of the standard in general. So it may not fit super well in the "general" diagram you have.

@tanay1337 tanay1337 merged commit 7f06c54 into main Jun 14, 2024
4 checks passed
@tanay1337 tanay1337 deleted the 7579 branch June 14, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants