Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

++ healthchecks to pg&redis #105

Merged
merged 2 commits into from
Aug 2, 2023
Merged

++ healthchecks to pg&redis #105

merged 2 commits into from
Aug 2, 2023

Conversation

mshakeg
Copy link
Contributor

@mshakeg mshakeg commented Jul 28, 2023

Fixes #104

@mshakeg
++ healthchecks to pg&redis
1c9c10b 
Signed-off-by: Mo Shaikjee <[email protected]>
@mshakeg mshakeg requested a review from a team as a code owner July 28, 2023 15:02
@mshakeg mshakeg requested review from Uxio0, moisses89 and akshay-ap and removed request for a team July 28, 2023 15:02
@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mshakeg
Copy link
Contributor Author

mshakeg commented Jul 28, 2023

Contributor License Agreement returns Page Not Found

@Uxio0
Copy link
Member

Uxio0 commented Aug 1, 2023

Contributor License Agreement returns Page Not Found

Noted, there was a typo on the url! Thanks! #108

Uxio0
Uxio0 requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for PR!

docker-compose.yml Outdated

cfg-db:
image: postgres:14-alpine
environment:
POSTGRES_PASSWORD: postgres
volumes:
- ./data/cfg-db:/var/lib/postgresql/data

healthcheck:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you inherit using <<: yaml so you don't have to define the same liveness multiple times for redis and postgres?

@mshakeg
Copy link
Contributor Author

mshakeg commented Aug 1, 2023 •
edited
Loading

I have read the CLA Document and I hereby sign the CLA

@mshakeg
Copy link
Contributor Author

mshakeg commented Aug 1, 2023

recheck

github-actions bot added a commit that referenced this pull request Aug 1, 2023
@github-actions
@mshakeg has signed the CLA in #105
88a7680
@mshakeg mshakeg requested a review from Uxio0 August 1, 2023 19:30
Uxio0
Uxio0 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks!

@Uxio0 Uxio0 merged commit 0d311fd into safe-global:main Aug 2, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@mshakeg mshakeg deleted the improve-docker-compose branch August 2, 2023 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 is a code owner automatically assigned from safe-global/safe-services

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap is a code owner automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Docker Compose file to improve service startup dependencies
2 participants
@mshakeg @Uxio0