-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
++ healthchecks to pg&redis #105
Conversation
Signed-off-by: Mo Shaikjee <[email protected]>
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor License Agreement returns Page Not Found |
Noted, there was a typo on the url! Thanks! #108 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for PR!
docker-compose.yml
Outdated
|
||
cfg-db: | ||
image: postgres:14-alpine | ||
environment: | ||
POSTGRES_PASSWORD: postgres | ||
volumes: | ||
- ./data/cfg-db:/var/lib/postgresql/data | ||
|
||
healthcheck: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you inherit using <<:
yaml so you don't have to define the same liveness multiple times for redis and postgres?
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, thanks!
Fixes #104