Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compose issues #119

Closed
wants to merge 2 commits into from
Closed

Conversation

bilbeyt
Copy link

@bilbeyt bilbeyt commented Oct 19, 2023

I had problems running docker-compose in my MAC and i solved problems with these changes.

  1. ui service change: for some reason, safe-wallet-web image has no contract types generated. (afterinstall is failing). I have adapted the command the fix the issue. (afterinstall doesn't generate contract types for typescript safe-wallet-web#2656)
  2. As cgw and ui are using different ports and cgw has no enabled cors, i couldnt use compose without setting cors headers for the cgw. (in a different setup for production this might not be a problem so i dont create issue for this nginx change in cgw repo)

@bilbeyt bilbeyt requested a review from a team as a code owner October 19, 2023 05:29
@bilbeyt bilbeyt requested review from fmrsabino, Uxio0 and hectorgomezv and removed request for a team October 19, 2023 05:29
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bilbeyt
Copy link
Author

bilbeyt commented Oct 19, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 19, 2023
@Uxio0
Copy link
Member

Uxio0 commented Nov 8, 2023

Hi @bilbeyt and thank you very much for your PR. We analyzed your solution but we decided to go with #121, which in our opinion makes configuration easier making UI and services run from the same nginx instance, so there's no CORS issues.

Again, thank you very much for your time.

@Uxio0 Uxio0 closed this Nov 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants