Fix Tx Service migrations execution dependencies #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falvaradorodriguez
requested review from
Uxio0,
moisses89 and
hectorgomezv
and removed request for
a team and
hectorgomezv
Uxio0
requested changes
May 3, 2024
| @@ -4,8 +4,6 @@ set -e | |||
|
|
|||
| echo "==> $(date +%H:%M:%S) ==> Starting up environment containers..." | |||
| docker compose up -d \ | |||
| && echo "==> $(date +%H:%M:%S) ==> Waiting for migrations... (may take a while)" \ | |||
There was a problem hiding this comment.
This is no longer necessary since the services have a startup dependency after applying the migrations.
Uxio0
approved these changes
May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #135
To start the txs-worker-notifications-webhooks and txs-worker-contracts-tokens services is needed the database ready and with the migrations executed.
For this, a Celery healthcheck validation is added in the service that executes the migrations. Celery is executed once the migrations are finished.
Then the dependent services are started when the Celery healthcheck is ok.