GH-3406 testing option of crash due to subtraction overflow

safe-global · May 31, 2024 · 8ffc02f · 8ffc02f
1 parent fb255a5
commit 8ffc02f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Multisig/UI/Settings/OwnerKeyManagement/KeystoneOwnerKey/KeystoneSignFlow.swift b/Multisig/UI/Settings/OwnerKeyManagement/KeystoneOwnerKey/KeystoneSignFlow.swift
@@ -126,7 +126,7 @@ extension SECP256K1.UnmarshaledSignature {
             } else {
                 // v still can be `{0, 1} + chainId * 2 + 35` for non-legacy transactions (chainId >=0)
                 if vInt >= 35 {
-                    let vRecovered = UInt64(vBytes) - chainIdTerm
+                    let vRecovered = (UInt64(vBytes) < chainIdTerm) ? 0 : (UInt64(vBytes) - chainIdTerm)
                     v = try! UInt8(vRecovered)
                 } else {
                     v = vInt