Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] The app crash on the QR code Keystone scanning #3406

Closed
liliya-soroka opened this issue Apr 30, 2024 · 2 comments
Closed

[iOS] The app crash on the QR code Keystone scanning #3406

liliya-soroka opened this issue Apr 30, 2024 · 2 comments
Labels
bug Doesn't work as expected

Comments

@liliya-soroka
Copy link
Member

liliya-soroka commented Apr 30, 2024 •
edited
Loading

Bug description
[iOS] The app crash on the QR code Keystone scanning
Steps To Reproduce

  1. try to connect Keystone and enable Push notification / sign/execute tx with the Keystone
    Current result: The app crashes on the scanning the second code from the keystone - https://console.firebase.google.com/u/0/project/safe-firebase-mainnet/crashlytics/app/ios:io.gnosis.multisig.prod.mainnet/issues/bff17878998e8811ba31e8d98b38cea4?time=last-seven-days&types=crash&versions=3.25.5%20(2002)&sessionEventKey=2f164f261f834b269eb678b189c36121_1942046290344744431

Expected Result
It should be possible to use Keystone without app crashing
Screenshots

Device & App version

  • Device/OS: iPhone11
  • App version: 3.25.5(2002)

Environment
prod
Additional info
(Optional)
@liliya-soroka liliya-soroka added the bug Doesn't work as expected label Apr 30, 2024
@liliya-soroka liliya-soroka changed the title [iOS] The app crash on the QA Keystone scanning [iOS] The app crash on the QR Keystone scanning Apr 30, 2024
@liliya-soroka liliya-soroka changed the title [iOS] The app crash on the QR Keystone scanning [iOS] The app crash on the QR code Keystone scanning Apr 30, 2024
@liliya-soroka liliya-soroka mentioned this issue May 7, 2024
Closed
DmitryBespalov added a commit that referenced this issue May 21, 2024
@DmitryBespalov
GH-3406 fixed crash
2924ecd 
was crashing in the `self.init(v:r:s:)` call.
Replacing with a tuple result and calling that initializer
later helped.
@DmitryBespalov DmitryBespalov mentioned this issue May 21, 2024
Merged
DmitryBespalov added a commit that referenced this issue May 21, 2024
@DmitryBespalov
Merge pull request #3413 from safe-global/GH-3406/fix-keystone-crash
1ed56cd 
GH-3406 fixed crash
@liliya-soroka
Copy link
Member Author

@DmitryBespalov , the app is crashing for me still.

Steps:

  1. try to sign the tx using Keystone
    Current result: the app crashes during signing process with Keystone

DmitryBespalov added a commit that referenced this issue May 31, 2024
@DmitryBespalov
GH-3406 another attempt to fix crash
4c70747 
Potential reason: crash in arithmetic operations
@DmitryBespalov DmitryBespalov mentioned this issue May 31, 2024
Merged
DmitryBespalov added a commit that referenced this issue May 31, 2024
@DmitryBespalov
GH-3406 avoiding overflow on multiplication and addition in 64-bit
fb255a5
DmitryBespalov added a commit that referenced this issue May 31, 2024
@DmitryBespalov
Merge pull request #3420 from safe-global/GH-3406/crash-fix-2
f6a40a1 
GH-3406 another attempt to fix crash
DmitryBespalov added a commit that referenced this issue May 31, 2024
@DmitryBespalov
GH-3406 testing option of crash due to subtraction overflow
8ffc02f
@DmitryBespalov DmitryBespalov mentioned this issue May 31, 2024
Merged
DmitryBespalov added a commit that referenced this issue May 31, 2024
@DmitryBespalov
GH-3406 use if-else for better line location
76753a7
DmitryBespalov added a commit that referenced this issue May 31, 2024
@DmitryBespalov
Merge pull request #3421 from safe-global/GH-3406/crash-fix-2
a6be08e 
GH-3406 testing option of crash due to subtraction overflow
DmitryBespalov added a commit that referenced this issue Jun 3, 2024
@DmitryBespalov
GH-3406 test different conditional value
505a34d
DmitryBespalov added a commit that referenced this issue Jun 3, 2024
@DmitryBespalov
Merge pull request #3422 from safe-global/GH-3406/crash-fix-3
1da366c 
GH-3406 test different conditional value
DmitryBespalov added a commit that referenced this issue Jun 3, 2024
@DmitryBespalov
GH-3406 test using a static string object
b0f1cdf
@DmitryBespalov DmitryBespalov mentioned this issue Jun 3, 2024
Merged
DmitryBespalov added a commit that referenced this issue Jun 3, 2024
@DmitryBespalov
Merge pull request #3423 from safe-global/GH-3406/crash-fix-3
9987ba3 
GH-3406 test using a static string object
DmitryBespalov added a commit that referenced this issue Jun 3, 2024
@DmitryBespalov
GH-3406 revert to the production code
46bd8e8
@DmitryBespalov DmitryBespalov mentioned this issue Jun 3, 2024
Merged
DmitryBespalov added a commit that referenced this issue Jun 3, 2024
@DmitryBespalov
Merge pull request #3424 from safe-global/GH-3406/crash-fix-3
24c10ed 
GH-3406 revert to the production code
@DmitryBespalov DmitryBespalov added the blocked Can't be worked on label Jun 6, 2024
DmitryBespalov added a commit that referenced this issue Jun 12, 2024
@DmitryBespalov
GH-3406 update libs
d74b34d
@DmitryBespalov DmitryBespalov mentioned this issue Jun 12, 2024
Merged
DmitryBespalov added a commit that referenced this issue Jun 13, 2024
@DmitryBespalov
GH-3406 GH-3427 adjust export data flow
618a778 
* Added password strength requirements and meter
* Changed texts in instructions and success screens
DmitryBespalov added a commit that referenced this issue Jun 13, 2024
@DmitryBespalov
GH-3406 GH-3427 add comment on password score
00c24a4
DmitryBespalov added a commit that referenced this issue Jun 14, 2024
@DmitryBespalov
Merge pull request #3426 from safe-global/GH-3406/update-libs
76008f9 
GH-3406, GH-3427 update libs
@DmitryBespalov DmitryBespalov removed the blocked Can't be worked on label Jun 14, 2024
@liliya-soroka
Copy link
Member Author

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Doesn't work as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DmitryBespalov @liliya-soroka