Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3441 Updated the assets #3442

Merged
merged 3 commits into from
Aug 9, 2024
Merged

GH-3441 Updated the assets #3442

merged 3 commits into from
Aug 9, 2024

Conversation

DmitryBespalov
Copy link
Contributor

Handles #3411

Changes proposed in this pull request:

  • Added new assets (json files)
  • Created a script to patch 'networkAddresses' to be an array
  • Adapted Swift code fetching the deployment information
  • Updated tests

* Added new assets (json files)
* Created a script to patch 'networkAddresses' to be an array
* Adapted Swift code fetching the deployment information
* Updated tests
@DmitryBespalov DmitryBespalov self-assigned this Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 8.10%. Comparing base (62adaf3) to head (cd6e812).
Report is 1 commits behind head on main.

Files Patch % Lines
...reum/Sources/SafeDeployments/SafeDeployments.swift 0.00% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3442      +/-   ##
========================================
- Coverage   8.10%   8.10%   -0.01%     
========================================
  Files        796     796              
  Lines      45050   45060      +10     
========================================
  Hits        3650    3650              
- Misses     41400   41410      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit c2f63af into main Aug 9, 2024
3 of 4 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3441/update-deployments branch August 9, 2024 15:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
@DmitryBespalov DmitryBespalov restored the GH-3441/update-deployments branch August 16, 2024 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant