Format Source #109
Merged
Format Source #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutely |
mmv08
approved these changes
Oct 24, 2023
Pull Request Test Coverage Report for Build 6627713378
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just formats the source in the 4337 module repo so it is consistent. It is done with
prettier --ignore-path .gitignore --write .(I updated thepackage.jsonto include afmtscript that calls this exact incantation). Additionally, I noticed that.vscode/launch.jsonwas formatted, but it contained old Truffle stuff that is clearly not being used so I opted to remove the file instead of including its formatted source in this PR.As a follow up question - do you think it is worth enforcing formatting of TypeScript code at a CI level or not?Furthermore, this adds a check in CI to ensure that files are properly formatted.