Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit preparations: Update Solidity linting setup, fix TS linting #114

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Audit preparations: Update Solidity linting setup, fix TS linting #114

merged 1 commit into from
Oct 26, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Oct 25, 2023

This PR:

  • Updates solidity linting to the latest package versions, mirroring the setup from safe-contracts repo
  • Fix Typescript linting. There was no eslint configuration. For some reason, the command that does linting from safe-contracts hangs when specifying the whole directory (.), so I had to specify the exact directories to lint
  • Depends on Audit preparations: documentation enhancements, remove unused code #113

@mmv08 mmv08 requested a review from a team as a code owner October 25, 2023 15:08
@mmv08 mmv08 requested review from rmeissner, nlordell and akshay-ap and removed request for a team October 25, 2023 15:08
@mmv08 mmv08 force-pushed the 4337m-preparations-lint-setup branch from 29188a1 to 02c7852 Compare October 25, 2023 15:09
@coveralls
Copy link

coveralls commented Oct 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6651778778

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6641944562: 0.0%
Covered Lines: 26
Relevant Lines: 26
💛 - Coveralls

@mmv08 mmv08 force-pushed the 4337m-preparations-lint-setup branch from 02c7852 to 1150804 Compare October 25, 2023 15:37
@nlordell
Copy link
Collaborator

This PR should target 4337-module-audit-preparations right? It seems to include changes from #114 which makes it harder to review.

@mmv08 mmv08 changed the base branch from master to 4337-module-audit-preparations October 25, 2023 15:51
@mmv08
Copy link
Member Author

mmv08 commented Oct 25, 2023

This PR should target 4337-module-audit-preparations right? It seems to include changes from #114 which makes it harder to review.

Initially I wanted you to review the other one first, but this one is also fine

@mmv08 mmv08 force-pushed the 4337m-preparations-lint-setup branch from 1150804 to fd171c3 Compare October 25, 2023 16:07
nlordell
nlordell approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧹

@mmv08 mmv08 force-pushed the 4337m-preparations-lint-setup branch 2 times, most recently from e248481 to 1a9d2e2 Compare October 26, 2023 08:55
@mmv08 mmv08 force-pushed the 4337m-preparations-lint-setup branch from 1a9d2e2 to dcd582f Compare October 26, 2023 08:57
@mmv08 mmv08 merged commit 53349e2 into 4337-module-audit-preparations Oct 26, 2023
4 checks passed
@mmv08 mmv08 deleted the 4337m-preparations-lint-setup branch October 26, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlordell nlordell nlordell approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap was automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @coveralls @nlordell