Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package name to @safe-global/safe-erc4337, update description #210

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Update package name to @safe-global/safe-erc4337, update description #210

merged 3 commits into from
Jan 17, 2024

Conversation

akshay-ap
Copy link
Member

@akshay-ap akshay-ap commented Jan 16, 2024 •
edited
Loading

Fixes #208
Description of changes
This PR contains minor updates in the modules/4337/package.json.

  • Update package name
  • Update description
  • Update README
  • Update userOp.ts

@akshay-ap akshay-ap self-assigned this Jan 16, 2024
@akshay-ap akshay-ap requested a review from a team as a code owner January 16, 2024 16:37
@akshay-ap akshay-ap requested review from rmeissner, nlordell, mmv08 and remedcu and removed request for a team January 16, 2024 16:37
@coveralls
Copy link

coveralls commented Jan 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7545235684

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.738%
Totals Coverage Status
Change from base Build 7530194083: 0.0%
Covered Lines: 101
Relevant Lines: 110
💛 - Coveralls

mmv08
mmv08 requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mmv08 mmv08 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the readme needs to be updated as well. I'd check other places too

@akshay-ap akshay-ap requested a review from mmv08 January 16, 2024 16:53
mmv08
mmv08 reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some test files and folders that need to be renamed too.

@mmv08 mmv08 merged commit 8df406b into main Jan 17, 2024
11 checks passed
@mmv08 mmv08 deleted the fix-208-update-package-name branch January 17, 2024 10:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner is a code owner automatically assigned from safe-global/safe-protocol

@nlordell nlordell Awaiting requested review from nlordell nlordell is a code owner automatically assigned from safe-global/safe-protocol

@remedcu remedcu Awaiting requested review from remedcu remedcu is a code owner automatically assigned from safe-global/safe-protocol

Assignees

@akshay-ap akshay-ap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace EIP with ERC in the 4337 module package name
3 participants
@akshay-ap @coveralls @mmv08