Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature length check #453

Merged
merged 52 commits into from
Jul 12, 2024
Merged

Signature length check #453

merged 52 commits into from
Jul 12, 2024

Commits on Jul 1, 2024

  1. [#754] WIP: Signature length check

    @akshay-ap
    akshay-ap committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    9c9136b View commit details
    Browse the repository at this point in the history

  2. [#754] Update comment in SafeL2Mod

    @akshay-ap
    akshay-ap committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c512034 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. [#754] Add signature length checks in Safe4337Module

    @akshay-ap
    akshay-ap committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    6ffaaf8 View commit details
    Browse the repository at this point in the history

  2. [#754] Fix lint issues

    @akshay-ap
    akshay-ap committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    78ef010 View commit details
    Browse the repository at this point in the history

  3. [#754] Summarize _checkSignatureLength function

    @akshay-ap
    akshay-ap committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f61aec6 View commit details
    Browse the repository at this point in the history

  4. [#754] Update comment

    @akshay-ap
    akshay-ap committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c72d37f View commit details
    Browse the repository at this point in the history

  5. [#754] Remove commented code

    @akshay-ap
    akshay-ap committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    7fc14c1 View commit details
    Browse the repository at this point in the history

  6. [#754] Use calldataload instruction

    @akshay-ap
    akshay-ap committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    2754975 View commit details
    Browse the repository at this point in the history

  7. [#754] Fixes

    @akshay-ap
    akshay-ap committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    032c7a3 View commit details
    Browse the repository at this point in the history

  8. [#754] Fixes

    @akshay-ap
    akshay-ap committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    17e6d46 View commit details
    Browse the repository at this point in the history

  9. [#754] Update tests

    @akshay-ap
    akshay-ap committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    9e22daf View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Update modules/4337/certora/specs/Safe4337Module.spec 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    dd43fe3 View commit details
    Browse the repository at this point in the history

  2. Update modules/4337/certora/specs/ValidationDataLastBitOne.spec 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d5cb574 View commit details
    Browse the repository at this point in the history

  3. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fce0584 View commit details
    Browse the repository at this point in the history

  4. [#754] Add comment on signature encoding in _checkSignatureLength

    @akshay-ap
    akshay-ap committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    9e526d6 View commit details
    Browse the repository at this point in the history

  5. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8450bb7 View commit details
    Browse the repository at this point in the history

  6. [#754] Update gas estimates and fix compilation error

    @akshay-ap
    akshay-ap committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    9c131c6 View commit details
    Browse the repository at this point in the history

  7. [#754] Fix lint issue

    @akshay-ap
    akshay-ap committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c8702f6 View commit details
    Browse the repository at this point in the history

  8. [#754] Adjust signature check logic

    @akshay-ap
    akshay-ap committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d83e133 View commit details
    Browse the repository at this point in the history

  9. [#754] Update comment, adjust _validateSignatures

    @akshay-ap
    akshay-ap committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    affd342 View commit details
    Browse the repository at this point in the history

  10. Update modules/4337/certora/specs/ValidationDataLastBitOne.spec 

    Co-authored-by: Shebin John <[email protected]>
    @akshay-ap @remedcu
    akshay-ap and remedcu authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    9047334 View commit details
    Browse the repository at this point in the history

  11. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Shebin John <[email protected]>
    @akshay-ap @remedcu
    akshay-ap and remedcu authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    001c6ce View commit details
    Browse the repository at this point in the history

  12. [#754] Rename variables, add comments

    @akshay-ap
    akshay-ap committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    af3b708 View commit details
    Browse the repository at this point in the history

  13. [#754] Lint fix

    @akshay-ap
    akshay-ap committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d8ba708 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. [#754] Add tests

    @akshay-ap
    akshay-ap committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    22fc197 View commit details
    Browse the repository at this point in the history

  2. [#754] Rename variable

    @akshay-ap
    akshay-ap committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    53345a6 View commit details
    Browse the repository at this point in the history

  3. [#754] Update comment

    @akshay-ap
    akshay-ap committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1c31fda View commit details
    Browse the repository at this point in the history

  4. Update modules/4337/test/erc4337/ERC4337ModuleNew.spec.ts 

    Co-authored-by: Shebin John <[email protected]>
    @akshay-ap @remedcu
    akshay-ap and remedcu authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    195f792 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    3975d8f View commit details
    Browse the repository at this point in the history

  2. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    16c7b8b View commit details
    Browse the repository at this point in the history

  3. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    3a37597 View commit details
    Browse the repository at this point in the history

  4. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5fa8afd View commit details
    Browse the repository at this point in the history

  5. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c2a0770 View commit details
    Browse the repository at this point in the history

  6. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e7c2348 View commit details
    Browse the repository at this point in the history

  7. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    3ef2a22 View commit details
    Browse the repository at this point in the history

  8. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    db87077 View commit details
    Browse the repository at this point in the history

  9. [#754] Update Natspec

    @akshay-ap
    akshay-ap committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f7ecfc6 View commit details
    Browse the repository at this point in the history

  10. [#754] Update comments in _checkSignatureLength

    @akshay-ap
    akshay-ap committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    979b6a4 View commit details
    Browse the repository at this point in the history

  11. [#754] Update variable name to expectedOffset

    @akshay-ap
    akshay-ap committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ca9e575 View commit details
    Browse the repository at this point in the history

  12. [#754] Add tests

    @akshay-ap
    akshay-ap committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1ec9813 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Update modules/4337/contracts/Safe4337Module.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    be6a6f5 View commit details
    Browse the repository at this point in the history

  2. [#754] Rename function, remove if-else

    @akshay-ap
    akshay-ap committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2743e53 View commit details
    Browse the repository at this point in the history

  3. [#754] Update comment on fixed signature part

    @akshay-ap
    akshay-ap committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    025234f View commit details
    Browse the repository at this point in the history

  4. [#754] Run tests

    @akshay-ap
    akshay-ap committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c54c89d View commit details
    Browse the repository at this point in the history

  5. Update modules/4337/test/erc4337/ReferenceEntryPoint.spec.ts 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    db5fcba View commit details
    Browse the repository at this point in the history

  6. Update modules/4337/test/erc4337/ReferenceEntryPoint.spec.ts 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ab66109 View commit details
    Browse the repository at this point in the history

  7. Update modules/4337/test/erc4337/ReferenceEntryPoint.spec.ts 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    31798cb View commit details
    Browse the repository at this point in the history

  8. [#754] Update test

    @akshay-ap
    akshay-ap committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    42b216e View commit details
    Browse the repository at this point in the history

  9. [#754] Update tests

    @akshay-ap
    akshay-ap committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0306c39 View commit details
    Browse the repository at this point in the history

  10. Refactor Length Check Implementation 

    Here, we refactor the length check to not use assembly (as we didn't
have a compelling argument to do so). Additionally, we added an escape
hatch on the length check validation in order to allow empty signature
(a reasonable "default" value) to not revert on `validateUserOp` for
better developer experience with 4337, which required an additional test
for full coverage.
    @nlordell
    nlordell committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    16e7b14 View commit details
    Browse the repository at this point in the history

  11. Cleanup Post-Review

    @nlordell
    nlordell committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    405a5ba View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. [#754] Lint fix

    @akshay-ap
    akshay-ap committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    09c4000 View commit details
    Browse the repository at this point in the history