Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment in _checkSignaturesLength regarding dynamic signatures #471

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Add comment in _checkSignaturesLength regarding dynamic signatures #471

merged 12 commits into from
Aug 27, 2024

Conversation

akshay-ap
Copy link
Member

This PR adds a comment on dynamic signatures and signature length manipulation in _checkSignaturesLength Natspec

@akshay-ap akshay-ap self-assigned this Jul 22, 2024
@akshay-ap akshay-ap requested a review from a team as a code owner July 22, 2024 09:06
@akshay-ap akshay-ap requested review from nlordell, mmv08 and remedcu and removed request for a team July 22, 2024 09:06
@coveralls
Copy link

coveralls commented Jul 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10561094866

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10008091065: 0.0%
Covered Lines: 51
Relevant Lines: 51
💛 - Coveralls

@akshay-ap akshay-ap force-pushed the feature-comment-on-dynamic-signatures branch from db13f9c to 229d1ff Compare July 22, 2024 10:34
@akshay-ap akshay-ap merged commit 120220b into main Aug 27, 2024
13 of 14 checks passed
@akshay-ap akshay-ap deleted the feature-comment-on-dynamic-signatures branch August 27, 2024 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

@mmv08 mmv08 Awaiting requested review from mmv08 mmv08 is a code owner automatically assigned from safe-global/safe-protocol

@remedcu remedcu Awaiting requested review from remedcu

Assignees

@akshay-ap akshay-ap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akshay-ap @coveralls @nlordell @remedcu