ERC4337 module feature: Extract execution to a separate function and require success in the internal call #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
requested review from
a team,
rmeissner,
Uxio0 and
akshay-ap
and removed request for
a team
mmv08
force-pushed
the
feature/require-success-for-operation-execution
branch
from
6c3e5f5
to
f565930
Compare
mmv08
commented
Oct 16, 2023
4337/contracts/EIP4337Module.sol
Outdated
| address entryPoint = _msgSender(); | ||
| require(entryPoint == supportedEntryPoint, "Unsupported entry point"); | ||
|
|
||
| (bool success, ) = msg.sender.call(executionData); |
There was a problem hiding this comment.
do you think we'd benefit from an additional check for the execTransactionFromModule signature?
mmv08
force-pushed
the
feature/require-success-for-operation-execution
branch
from
f565930
to
aed12a3
Compare
rmeissner
reviewed
Oct 17, 2023
rmeissner
reviewed
Oct 17, 2023
rmeissner
reviewed
Oct 17, 2023
mmv08
force-pushed
the
feature/require-success-for-operation-execution
branch
from
aed12a3
to
e381527
Compare
mmv08
force-pushed
the
feature/require-success-for-operation-execution
branch
2 times, most recently
from
9cfd4dc
to
b40d9c6
Compare
rmeissner
approved these changes
Oct 17, 2023
mmv08
force-pushed
the
feature/require-success-for-operation-execution
branch
from
b40d9c6
to
907e849
Compare
rmeissner
approved these changes
Oct 18, 2023
mmv08
force-pushed
the
feature/require-success-for-operation-execution
branch
from
ad89aa2
to
02c1a14
Compare
mmv08
force-pushed
the
feature/require-success-for-operation-execution
branch
from
02c1a14
to
ca698b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
execTransactionFromModuleand had to be enabled as a module as wellsuccessand revert on failing transactions to enable a proper gas estimationThis PR is a prototype only at the moment, and the goal is to seek the team's feedback on the approach.