Fix github actions

safe-global · Nov 23, 2023 · 6307d31 · 6307d31
1 parent 20696e9
commit 6307d31
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 49 deletions.
diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
@@ -31,37 +31,6 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.11"]
-    services:
-      redis:
-        image: redis
-        options: >-
-          --health-cmd "redis-cli ping"
-          --health-interval 10s
-          --health-timeout 5s
-          --health-retries 5
-        ports:
-          - 6379:6379
-      postgres:
-        image: postgres:14
-        env:
-          POSTGRES_USER: postgres
-          POSTGRES_PASSWORD: postgres
-        options: >-
-          --health-cmd pg_isready
-          --health-interval 10s
-          --health-timeout 5s
-          --health-retries 5
-        ports:
-          - 5432:5432
-      rabbitmq:
-        image: rabbitmq:alpine
-        options: >-
-          --health-cmd "rabbitmqctl await_startup"
-          --health-interval 10s
-          --health-timeout 5s
-          --health-retries 5
-        ports:
-          - "5672:5672"
     steps:
     - name: Setup and run ganache
       run: |
@@ -86,7 +55,6 @@ jobs:
         coverage run --source=$SOURCE_FOLDER -m pytest -rxXs --reruns 3
       env:
         SOURCE_FOLDER: safe_price_service
-        DATABASE_URL: psql://postgres:postgres@localhost/postgres
         DJANGO_SETTINGS_MODULE: config.settings.test
         ETHEREUM_MAINNET_NODE: ${{ secrets.ETHEREUM_MAINNET_NODE }}
         ETHEREUM_NODES_URLS: http://localhost:8545

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -15,21 +15,6 @@ services:
     depends_on:
       - web
 
-  redis:
-    image: redis:alpine
-    ports:
-      - "6379:6379"
-    command:
-      - --appendonly yes
-
-  db:
-    image: postgres:14-alpine
-    ports:
-      - "5432:5432"
-    environment:
-      POSTGRES_USER: postgres
-      POSTGRES_PASSWORD: postgres
-
   web:
     build:
       context: .

diff --git a/safe_price_service/tokens/tests/test_price_service.py b/safe_price_service/tokens/tests/test_price_service.py
@@ -379,7 +379,7 @@ def test_get_token_usd_price(self):
                 self.assertAlmostEqual(
                     token_fiat_price_with_timestamp.fiat_price,
                     token_fiat_price_with_timestamp_from_coingecko.fiat_price,
-                    delta=5.0,
+                    delta=10.0,
                 )
 
     def test_get_token_usd_price_native_coin(self):

diff --git a/safe_price_service/utils/exceptions.py b/safe_price_service/utils/exceptions.py
@@ -8,7 +8,6 @@
 
 
 def custom_exception_handler(exc, context):
-
     if isinstance(exc, NodeConnectionException):
         response = Response(status=status.HTTP_503_SERVICE_UNAVAILABLE)