Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-connect): Improved Walletconnect rejection messages to dApps #729

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

DaniSomoza
Copy link
Contributor

@DaniSomoza DaniSomoza commented Jul 10, 2023

What it solves

Added new Walletconnect rejection messages

Connection refused: the dApp you are using is sending a connection proposal that is incompatible with your Safe Account

How this PR fixes it

How to test it

Screenshots

Captura de pantalla 2023-07-10 a las 11 41 42

@DaniSomoza DaniSomoza requested a review from yagopv July 10, 2023 09:30
@DaniSomoza DaniSomoza changed the title fix(wallet-connect): Add new Walletconnect rejection messages fix(wallet-connect): Improced Walletconnect rejection messages to dApps Jul 10, 2023
@DaniSomoza DaniSomoza changed the title fix(wallet-connect): Improced Walletconnect rejection messages to dApps fix(wallet-connect): Improved Walletconnect rejection messages to dApps Jul 10, 2023
@DaniSomoza DaniSomoza merged commit e7b8b2c into development Jul 10, 2023
7 of 8 checks passed
@DaniSomoza DaniSomoza deleted the fix-improved-walletconnect-rejection-messages branch July 10, 2023 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants