Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tx-builder): Add dark mode support #825

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

clovisdasilvaneto
Copy link
Contributor

@clovisdasilvaneto clovisdasilvaneto commented Oct 9, 2024

What it solves

Resolves #824

How this PR fixes it

It adds dark mode theme palette into the project and set the theme based on the postMessage event which we receive from the safe wallet app.

How to test it

Video

txbuilder.webm

@clovisdasilvaneto clovisdasilvaneto self-assigned this Oct 9, 2024
@clovisdasilvaneto clovisdasilvaneto changed the title Feat(tx-builder) Add dark mode support feat(tx-builder) Add dark mode support Oct 9, 2024
@clovisdasilvaneto clovisdasilvaneto changed the title feat(tx-builder) Add dark mode support feat(tx-builder): Add dark mode support Oct 9, 2024
@francovenica
Copy link

Issues:

1 - The form when you edit a tx that is batched on the right side is still white:
image
image

2 - The list of saved batches show the list of them white as well:
For this you must save it in the library first:
image

Go to Your tx library:
image

And then you see this:
image

@clovisdasilvaneto
Copy link
Contributor Author

@francovenica thanks! I'll take a look on them

@clovisdasilvaneto
Copy link
Contributor Author

clovisdasilvaneto commented Oct 9, 2024

@francovenica done ✅ Can you please check that again? Please make sure to clear your cache  😉

@francovenica
Copy link

I think the fixes broke some stuff in light mode now:

The saved batches, there is a number that should be white
There is a gray background that should be white
image
image

Same in the tx edition:
For the light mode there is a gray background when in dev is fully white. A comparison here:
image

in dev:
image

Also in the dark mode I think the whole modal should be gray. Compare it with any other tx in the site:

The tx edition in the tx builder:
image

A regular tx color:
image

@clovisdasilvaneto
Copy link
Contributor Author

@francovenica can you please check that again?

@francovenica
Copy link

All the issues fixed
LGTM now.

@clovisdasilvaneto clovisdasilvaneto merged commit 8d80661 into development Oct 11, 2024
6 of 7 checks passed
@clovisdasilvaneto clovisdasilvaneto deleted the feat/tx-builder-dark-mode branch October 11, 2024 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
@clovisdasilvaneto clovisdasilvaneto restored the feat/tx-builder-dark-mode branch October 18, 2024 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add safe wallet dark mode support in the transaction builder
3 participants